Repository navigation
fix(driver): do not crash on EPIPE after the client exits - #43499
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Open
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
When a language binding exits while the driver still sends messages, the write to stdout fails with EPIPE. Without an error listener the driver crashes before it closes the browsers, so a launched browser can outlive the client. Ignore the error; the driver still exits gracefully when stdin closes.
Contributor
Test results for "tests 1"3 flaky23577 passed, 712 skipped Merge workflow run. |
Contributor
Test results for "MCP"5154 passed, 614 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runDriver()had noerrorlistener onprocess.stdout, so a write after the client exited crashed the driver with EPIPE before it closed the browsers.SI-005/SI-006(browser process exit on client kill) in playwright-python on WebKit.