Pull Pylance with Pyright 1.1.411 - #11631
Conversation
|
🔒 Automated review in progress — Stella Huang (@StellaHuang95) is auto-reviewing this PR. |
| env: | ||
| NPM_CONFIG_USERCONFIG: ${{ runner.temp }}/cfs-npm-auth/.npmrc | ||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: ${{ inputs.skip-playwright-browser-download }} | ||
| run: pnpm install --frozen-lockfile --prefer-offline |
There was a problem hiding this comment.
Warning · Non-blocking recommendation
The trusted path uses a frozen lockfile, but the fork path uses pnpm run install:all without equivalent lockfile strictness. This can let fork CI pass after lockfile drift that trusted CI rejects; please align the install commands or document why the divergence is intentional. [verified]
|
|
||
| if (transitive) { | ||
| console.log('removing pnpm-lock.yaml and node_modules'); | ||
| await fsAsync.unlink('pnpm-lock.yaml'); |
There was a problem hiding this comment.
Info · Optional note
fsAsync.unlink('pnpm-lock.yaml') rejects when the lockfile is absent, aborting this maintenance script. Use a forced removal or handle ENOENT so the update remains idempotent. [verified]
|
A permanent regression test adds a prohibited issue URL and should be corrected before merge. The CI lockfile strictness and update-script robustness findings are non-blocking. |
|
The update adds a permanent regression-test header with a prohibited issue URL, which must be removed before merge. |
Stella Huang (StellaHuang95)
added
the
review-auto:changes-requested
2 participants
No description provided.