Repository navigation
Conversation
…ot a directory `CreateDirectoryDeepNoThrow(L"C:\\foo")` call succeeds if `C:\foo` is a regular file. It can be confusing because existing directory at `C:\foo` is expected after the succeeded call.
nikola-sh
force-pushed
the
fix_create_dir_for_file
branch
from
October 2, 2026 14:02
ab8e17d to
83622e0
Compare
nikola-sh
marked this pull request as ready for review
October 2, 2026 14:56
nikola-sh
changed the title
CreateDirectoryDeepNoThrow must fail if the path exists and it is not a directory
Duncan Horn (dunhor)
approved these changes
Oct 21, 2026
Duncan Horn (dunhor)
left a comment
Duncan Horn (dunhor)
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks!
Member
|
Build failure looks related to either an MSVC or Clang update. I'll look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateDirectoryDeepNoThrow(L"C:\\foo")call succeeds ifC:\foois a regular file. It can be confusing because a directory is expected to be atC:\fooafter the succeeded call.