Skip to content

fix(svo-adapter): read the public base URL from SVO_ADAPTER_PUBLIC_URL as well - #378

Open
wmobley wants to merge 1 commit into
developfrom
fix/svo-adapter-public-url-alias
Open

wmobley wants to merge 1 commit into
developfrom
fix/svo-adapter-public-url-alias

Conversation

@wmobley

@wmobley wmobley commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Why

Enabling the token keeper on the dev pod (#377) made the pod fail startup validation with SVO_ADAPTER_PUBLIC_URL is empty, although the pod has that variable set. The settings field is public_base_url, which pydantic-settings maps to SVO_ADAPTER_PUBLIC_BASE_URL; the deploy tooling, docs and pod use SVO_ADAPTER_PUBLIC_URL. So the value was never read, which also means run signals (#375) were silently unconfigured on the dev pod until now.

What

  • Settings.public_base_url accepts both SVO_ADAPTER_PUBLIC_URL (deploy spelling, wins) and SVO_ADAPTER_PUBLIC_BASE_URL.
  • The keeper's validation error names both.
  • Regression test tests/test_config_public_url.py.

The dev pod was restored immediately by also setting SVO_ADAPTER_PUBLIC_BASE_URL; after this merges either name works. Verified live after the restore: /health ok, POST /runs/{id}/token and POST /runs/{id}/signal both answer the uniform 401 for a bogus credential, i.e. signals and the keeper are configured.

🤖 Generated with Claude Code

…L as well

The deploy tooling, the dev pod and the docs set SVO_ADAPTER_PUBLIC_URL, but
the settings field is public_base_url, which pydantic-settings maps to
SVO_ADAPTER_PUBLIC_BASE_URL. The value was therefore never read: run signals
were silently unconfigured on the dev pod, and the token keeper's startup
validation refused to start the pod once it was enabled (2026-11-03).

Accept both names, deploy spelling first, and name both in the validation
error. The pod was restored by also setting SVO_ADAPTER_PUBLIC_BASE_URL.
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 3, 2026 9:47pm UTC

This branch was successfully deployed

1 active deployment
Preview — cb4c95d4 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant