Use out-channel-redirect and add wasm_of_ocaml support - #436
Open
hhugo wants to merge 11 commits into
Open
Conversation
Replace custom C stubs and JS runtime for dup/dup2-based redirection with the out-channel-redirect library, which handles native, JS, and wasm targets.
Install binaryen and wasm_of_ocaml-compiler in CI, then run @runtest-wasm with WASM_OF_OCAML=true on OCaml >= 4.14.
hhugo
marked this pull request as draft
March 31, 2026 14:17
Contributor
Author
|
Draft because https://github.com/hhugo/out-channel-redirect is not yet released |
Virtual package pulling in wasm_of_ocaml-compiler alongside alcotest, mirroring alcotest-js for JavaScript.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When matrix.opam-local-packages is unset, it evaluates to "" which
overrides setup-ocaml's default of *.opam, causing local packages
not to be pinned. This makes the solver unable to resolve
alcotest {= version} from alcotest-wasm.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hhugo
force-pushed
the
use-out-channel-redirect
branch
from
April 3, 2026 10:26
4fdf616 to
957ae5c
Compare
hhugo
marked this pull request as ready for review
April 3, 2026 12:30
Member
|
Downstream confirmation: ocaml-wire's full test suite runs under The downstream CI and workaround are here: Once this merges and is released, we can remove that environment override. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alcotest-wasmvirtual package (mirroringalcotest-js)Test plan
🤖 Generated with Claude Code