Add --names to generate static names for crunched files - #73
Open
er433 wants to merge 1 commit into
Open
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the generated module is accessed by strings, so a bad path compiles fine and fails at run time:
This PR adds a
--namesflag that generates a module with one value per crunched file, named after its path, so the compiler checks the reference:Now, in this way, we'll have a compile time error if passing a "bad path".
The generated module exposes an abstract type with
name,path,contentsandsizeaccessors plus analllist.It also carries its own
module type Slisting just the bindings, which lets a wrapper library re-export the names while hiding everything else... this might be useful when the contents should not be readable directly:I think this covers partially the request of #44 , although I discovered the issue afterwards.
Disclaimer: the changes in this PR were partially made with AI-assisted coding using Claude Code.