revert(backend): revert compile-config - #17411
Open
kakkokari-gtyih wants to merge 25 commits into
Open
Conversation
This reverts commit 1facca1.
github-actions
Bot
added
packages/backend
Contributor
|
このPRによるapi.jsonの差分 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17411 +/- ##
============================================
+ Coverage 14.12% 26.22% +12.09%
============================================
Files 247 1174 +927
Lines 11958 40039 +28081
Branches 4033 11117 +7084
============================================
+ Hits 1689 10499 +8810
- Misses 8050 23708 +15658
- Partials 2219 5832 +3613 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
⚙️ Backend Diagnostics ReportMemory: After GC
Only metrics showing significant changes are displayed. V8 Heap Snapshot Statistics
|
kakkokari-gtyih
marked this pull request as ready for review
May 15, 2026 08:44
dosubot
Bot
added
the
size:L
…gtyih/misskey into revert-compile-config
1 task
Member
|
17075 リンクしました |
Member
Author
|
👀 |
Member
Author
|
コンフリクト解消 |
…gtyih/misskey into revert-compile-config
Member
Author
|
yamlをv5にしてきた |
Contributor
📦 Frontend Bundle ReportChunk size diff (0 updated, 0 added, 0 removed)No data Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for Bundle Stats
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
コンフリクト解消 |
Member
Author
|
コンフリクト解消 |
Member
Author
|
コンフリクト解消 |
Member
Author
|
コンフリクト解消 |
Contributor
📦 Frontend Bundle ReportChunk size diff (0 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for Bundle Stats
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
api.jsonの差分作成中にエラーが発生しました。詳細はWorkflowのログを確認してください。 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough設定コンパイル済みJSONの利用を廃止し、YAML設定と Changes設定読み込みとマイグレーション
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change reverts compile-config behavior and updates related backend configuration paths. No actionable merge-blocking risk remains; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant BackendCommand
participant ConfigLoader
participant YAMLFile
participant Migration
BackendCommand->>ConfigLoader: loadConfig()
ConfigLoader->>YAMLFile: 設定YAMLを読み込み
YAMLFile-->>ConfigLoader: 設定値
Migration->>ConfigLoader: マイグレーション設定を取得
ConfigLoader-->>Migration: DEFAULT値と実行判定
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
30-32: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win起動手順の変更を
CHANGELOG.mdに記録してください。
start/start:inspect/start:testの実行契約を変更しており、運用者や開発者に影響します。CHANGELOG.mdの## Unreleased配下へFixまたはEnhanceを1行追加済みか確認してください。Based on learnings: ユーザー影響のある変更には
CHANGELOG.mdへ記録する必要があります。 PR checklist でも changelog は未完了として扱われています。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 30 - 32, package.json の start、start:inspect、start:test の起動手順変更を CHANGELOG.md の「## Unreleased」配下に Fix または Enhance として1行追記し、運用者と開発者に影響する変更内容を簡潔に記録してください。Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/backend-diagnostics.inspect.yml:
- Line 71: Update the “Configure base” job step to preserve the existing
compile-config behavior by running pnpm compile-config after copying the test
YAML, while keeping the head-side configuration flow YAML-only. Ensure the base
checkout can produce the built configuration expected by the legacy develop
contract.
---
Nitpick comments:
In `@package.json`:
- Around line 30-32: package.json の start、start:inspect、start:test の起動手順変更を
CHANGELOG.md の「## Unreleased」配下に Fix または Enhance
として1行追記し、運用者と開発者に影響する変更内容を簡潔に記録してください。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4f19b9e2-2042-4576-877d-3c3f754a4244
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
.claude/skills/working-on-backend/references/knowledge/backend-testing.md.claude/skills/working-on-backend/references/tasks/creating-migration.md.claude/skills/working-on-backend/scripts/prepare-generate.mjs.github/copilot-instructions.md.github/workflows/backend-diagnostics.inspect.ymlpackage.jsonpackages/backend/migration/1746949539915-migrateSomeConfigFileSettingsToMeta.jspackages/backend/migration/js/migration-config.jspackages/backend/ormconfig.jspackages/backend/package.jsonpackages/backend/scripts/compile_config.jspackages/backend/src/config.tspackages/backend/test-federation/.config/dummy.ymlpackages/backend/test-federation/.config/example.config.jsonpackages/backend/test-federation/.config/example.default.ymlpackages/backend/test-federation/compose.a.ymlpackages/backend/test-federation/compose.b.ymlpackages/backend/test-federation/compose.tpl.ymlpackages/backend/test-federation/compose.ymlpackages/backend/test-federation/setup.sh
💤 Files with no reviewable changes (6)
- packages/backend/test-federation/.config/dummy.yml
- packages/backend/scripts/compile_config.js
- packages/backend/test-federation/.config/example.config.json
- packages/backend/test-federation/compose.yml
- .claude/skills/working-on-backend/references/tasks/creating-migration.md
- packages/backend/test-federation/compose.tpl.yml
Member
|
js-yamlがv5になったことによりAPIが刷新され、名前付きエクスポートに対応したとのこと。 load関数単独で引き込めるようになったので、状況が改善している可能性が高いです（要計測） |
This was referenced Jul 30, 2026
Member
Author
|
コンフリクト解消 |
Member
Author
|
メモリ使用量的にはそんなに変化無さそう |
Contributor
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (0 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #17407
Fix #17075
Additional info (optional)
Checklist