fix test_install errors - #1032
Open
tsteven4 wants to merge 5 commits into
Open
Conversation
related to py7zr 1.1.3 and WARNING : Caught Bad7zFile, terminating installer workers ERROR : Specified path is bad: . These errors compromised our ability to mock archives that use extract_target such as those for qtpdf and qtwebengine extensions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesMock archive extraction path update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tsteven4
marked this pull request as draft
June 30, 2026 01:23
tsteven4
marked this pull request as ready for review
July 1, 2026 12:54
Contributor
Author
|
Here is the difference in the created archives. You can see the extraneous directory entry |
pzhlkj6612
reviewed
Jul 2, 2026
Comment on lines
+1170
to
+1171
| ( # extensions availability: qtpdf and qtwebengine | ||
| # add --keep to debug created mock archive |
Contributor
There was a problem hiding this comment.
maybe this is not that awkward?
Suggested change
| ( # extensions availability: qtpdf and qtwebengine | |
| # add --keep to debug created mock archive | |
| ( | |
| # extensions availability: qtpdf and qtwebengine | |
| # add --keep to debug created mock archive |
Contributor
Author
|
I note the new mock archive structure better matches the Qt archive we are mocking which doesn't have a '.' Directory: |
miurahr
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to py7zr 1.1.3 and
WARNING : Caught Bad7zFile, terminating installer workers
ERROR : Specified path is bad: .
These errors compromised our ability to mock archives that use extract_target such as those for qtpdf and qtwebengine extensions.
This should fix "Check tox tests" workflow.