Repository navigation
feat: heal and track urllib.request calls - #46
Merged
Merged
Conversation
The SDK wraps AbstractHTTPHandler.do_open, urllib's one hop on the wire for http and https. It sees the raw response for any status, before urllib raises HTTPError, so a healed call returns normally and an unhealed one raises the same HTTPError with its whole body. Failure bodies are read up to the capture cap and handed back on the same HTTPResponse, followed by the unread rest. File and iterable request bodies are never read. The retry keeps the request's method and its proxy.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What changed
main. Same commit, cherry-picked, no changes.💭 Why
#44 was stacked on #43's branch and merged after #43 was squash-merged, so it went into
add-http-client-supportinstead ofmain.mainhas aiohttp but no urllib.👤 For users
A healed
urlopencall returns normally instead of raisingHTTPError. An unhealed one raises the sameHTTPError, full body readable.📝 Notes
aa9837eexactly.mnfst/appmain with an operator-approved patch.