Repository navigation
netlink: add unit tests for IPVS service, destination, and statistics decoding - #48
Merged
Merged
Conversation
Add table-driven tests for assembleService and assembleDestination, covering IPv4 and IPv6 addresses and their corresponding netlink attributes. Verify decoding of service persistence engine names, destination weights larger than 16 bits, and persistent connection counts. Also verify that attribute ordering does not affect decoding and that unknown attributes are ignored for forward compatibility. These tests exercise the decoding functions directly, without requiring network namespaces or elevated privileges. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
add_decoding_tests
branch
from
October 13, 2026 15:16
35f1a07 to
55302f6
Compare
Add table-driven tests for assembleStats, covering all supported statistics attributes, including 32-bit counters and 64-bit byte counts. Verify that unknown attributes are ignored without interrupting decoding, and that malformed netlink attributes return an error. These tests exercise the decoder without requiring network namespaces or elevated privileges, and provide baseline coverage for future STATS64 support. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
robmry
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add table-driven tests for assembleService and assembleDestination, covering IPv4 and IPv6 addresses and their corresponding netlink attributes.
Verify decoding of service persistence engine names, destination weights larger than 16 bits, and persistent connection counts.
Also verify that attribute ordering does not affect decoding and that unknown attributes are ignored for forward compatibility.
These tests exercise the decoding functions directly, without requiring network namespaces or elevated privileges.