refactor(build): remove unused interceptor - #633
Merged
Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request removes the previously supported (but now unused) build “interceptor” feature from the backend build pipeline, simplifying the builder implementation and eliminating related configuration and test code.
Changes:
- Removed the
interceptorpackage/interface and all builder integration points. - Dropped the
WithInterceptoroption and the corresponding config field. - Deleted the
splitReaderhelper and its dedicated test (TestPipeReader) that only existed to support interceptor concurrency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/backend/build/interceptor/interceptor.go | Deletes the interceptor interface/package that is no longer used. |
| pkg/backend/build/config.go | Removes the interceptor option/field from builder configuration. |
| pkg/backend/build/builder.go | Removes interceptor plumbing and the splitReader concurrency helper from the build path. |
| pkg/backend/build/builder_test.go | Removes the now-obsolete TestPipeReader and related imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the build "interceptor" feature from the codebase, including all related logic, configuration, and tests. The interceptor was previously used to intercept and modify the build process, but is no longer needed.
Removal of interceptor functionality:
interceptorpackage and its interface, along with all related code inpkg/backend/build/interceptor/interceptor.go.interceptorfield and logic from theabstractBuilderstruct and its methods inpkg/backend/build/builder.go, including thesplitReaderhelper function and all associated concurrency code. [1] [2] [3] [4] [5]WithInterceptoroption and related configuration frompkg/backend/build/config.go. [1] [2]Test cleanup:
TestPipeReadertest and associated imports frompkg/backend/build/builder_test.go, as it was only used for the interceptor feature. [1] [2]These changes simplify the codebase by eliminating unused interceptor logic and related complexity.