refactor(i18n): use common messages for generic button labels - #7020
Merged
Conversation
A few components defined their own "Cancel", "Close", "Clear" and "Success" descriptors when commonMessages already has them. Swapped them over and removed the old ones. Locale files come from intl:prune-local dropping the now-orphaned strings across every language.
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Prospector
approved these changes
Aug 6, 2026
Member
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 7 hours 45 minutes 12 seconds in the queue, including 6 minutes 43 seconds running CI. Required conditions to merge
|
10 tasks
Member
|
@Mergifyio refresh |
✅ Pull request refreshed |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonMessagesalready has "Cancel", "Close", "Clear" and "Success",but a few components were defining their own. Swapped them over and
removed the old ones.
Nothing changes — the defaultMessages were identical.
The locale diff is just
pnpm preprpruning the orphaned strings out ofevery language.