Skip to content

impr(quotes): add two English quotes (@RedPandaGuy1234) - #8291

Open
RedPandaGuy1234 wants to merge 14 commits into
monkeytypegame:masterfrom
RedPandaGuy1234:master
Open

impr(quotes): add two English quotes (@RedPandaGuy1234)#8291
RedPandaGuy1234 wants to merge 14 commits into
monkeytypegame:masterfrom
RedPandaGuy1234:master

Conversation

@RedPandaGuy1234

@RedPandaGuy1234 RedPandaGuy1234 commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

This was originally in #8284, but was now fixed. This adds one new English quote from Harry Potter and the Deathly Hallows and fixes a formatting error.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jul 27, 2026
@RedPandaGuy1234

RedPandaGuy1234 commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

I had to add the second commit changing the workflow file because the --check flag was still in the check-formatting.yml file, and the "check formatting" check would fail without deleting it.

@RedPandaGuy1234 RedPandaGuy1234 changed the title impr(quotes): add an English quote (@RedPandaGuy1234) impr(quotes): add an English quote and fix a workflow file error (@RedPandaGuy1234) Jul 27, 2026
@RedPandaGuy1234
Adding a trivial line.
0c293c9 
This was just added to run the checks on monkeytypegame#8291 again.
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2026
@RedPandaGuy1234
Deleting the trivial line
de2afb4 
After the extra line was added, a different error occurred, so I deleted it.
@github-actions github-actions Bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2026
RedPandaGuy1234
RedPandaGuy1234 commented Jul 27, 2026
View reviewed changes
Comment thread .github/workflows/check-formatting.yml Outdated
@RedPandaGuy1234 RedPandaGuy1234 mentioned this pull request Jul 27, 2026
Open
22 tasks
@RedPandaGuy1234
Add another English quote
ce82b3e 
This quote is from The Hunger Games.
@RedPandaGuy1234 RedPandaGuy1234 changed the title impr(quotes): add an English quote and fix a workflow file error (@RedPandaGuy1234) impr(quotes): add two English quotes and fix a workflow file error (@RedPandaGuy1234) Jul 27, 2026
@fehmer fehmer added the format Ask the bot to fix formatting on this pr label Jul 27, 2026
RedPandaGuy1234
RedPandaGuy1234 commented Jul 27, 2026
View reviewed changes
Comment thread .github/workflows/check-formatting.yml Outdated
@RedPandaGuy1234

RedPandaGuy1234 commented Jul 27, 2026

Copy link
Copy Markdown
Author

This works! Could you approve it, so it can be merged @fehmer?

@fehmer

fehmer commented Jul 27, 2026

Copy link
Copy Markdown
Member

hi, mio approves/merges the pr.

@RedPandaGuy1234

RedPandaGuy1234 commented Jul 27, 2026

Copy link
Copy Markdown
Author

hi, mio approves/merges the pr.

Oh, okay. Thank you for helping me with this!

@RedPandaGuy1234

RedPandaGuy1234 commented Jul 27, 2026

Copy link
Copy Markdown
Author

The commit you added @fehmer fixed the recurring error that I had with my quotes.

@fehmer fehmer changed the title impr(quotes): add two English quotes and fix a workflow file error (@RedPandaGuy1234) impr(quotes): add two English quotes (@RedPandaGuy1234) Jul 28, 2026
@RedPandaGuy1234

RedPandaGuy1234 commented Jul 30, 2026

Copy link
Copy Markdown
Author

@fehmer Just for further reference, how did you fix the formatting issue?

@fehmer

fehmer commented Jul 31, 2026

Copy link
Copy Markdown
Member

by running pnpm format-fix

@RedPandaGuy1234

RedPandaGuy1234 commented Aug 2, 2026

Copy link
Copy Markdown
Author

by running pnpm format-fix

@fehmer where? Locally?

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Aug 5, 2026
@monkeytypegeorge monkeytypegeorge added the packages Changes in local packages label Aug 5, 2026
@github-actions github-actions Bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions Bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. format Ask the bot to fix formatting on this pr frontend User interface or web stuff packages Changes in local packages waiting for update Pull requests or issues that require changes/comments before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RedPandaGuy1234 @fehmer @monkeytypegeorge