Repository navigation
fix(auth): stabilize phone input editing and country codes - #372
Merged
Merged
Conversation
Keep phone values separate from display formatting to preserve selections, cursor positions, and digits during edits. Insert the selected dial code for national input, keep national digits when changing countries, and align placeholders with the exact country entry. Validate with 138 unit tests and 9 phone input interaction tests on Pixel 10 Pro XL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix phone input omitting the displayed country code when typing, duplicated dial codes in placeholders, and inconsistent editing behavior.
+and handle the configured IME action.Validation:
Developed with assistance from GPT-6.1-Sol (High).