Skip to content

fix(auth): stabilize phone input editing and country codes - #372

Merged
gdlbo merged 1 commit into
monogram-android:developfrom
SecondThundeR:fix/phone-input
Oct 18, 2026
Merged

gdlbo merged 1 commit into
monogram-android:developfrom
SecondThundeR:fix/phone-input

Conversation

@SecondThundeR

Copy link
Copy Markdown
Contributor

Fix phone input omitting the displayed country code when typing, duplicated dial codes in placeholders, and inconsistent editing behavior.

  • Separate stored phone values from display formatting to preserve cursor positions, selections, and digits.
  • Insert the selected dial code for national input while preserving international numbers.
  • Keep national digits when changing countries.
  • Correct shared-code detection and remember the exact country-picker entry.
  • Preserve a typed + and handle the configured IME action.

Validation:

  • 138 unit tests passed across core/common and auth.
  • All 9 phone-input interaction tests passed on Pixel 10 Pro XL.
  • Debug app and instrumentation APK builds passed.

Developed with assistance from GPT-6.1-Sol (High).

Keep phone values separate from display formatting to preserve selections, cursor positions, and digits during edits. Insert the selected dial code for national input, keep national digits when changing countries, and align placeholders with the exact country entry.

Validate with 138 unit tests and 9 phone input interaction tests on Pixel 10 Pro XL.
@gdlbo
gdlbo merged commit 5461646 into monogram-android:develop Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants