Bug 2022889 - Add MWU result caching to performance api - #9753
Open
gopar wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gopar
marked this pull request as draft
August 3, 2026 21:49
gopar
force-pushed
the
bug-2022889-add-caching-to-perf-api
branch
from
August 4, 2026 19:22
1f80d1b to
0b6b414
Compare
gopar
changed the title
gopar
marked this pull request as ready for review
August 4, 2026 19:38
gopar
commented
Aug 4, 2026
|
|
||
|
|
||
| class PerfCompareMwuCache(models.Model): | ||
| hash_key = models.CharField(max_length=64, unique=True, db_index=True) |
Author
There was a problem hiding this comment.
Added index since I'm not sure how big this table will grow. (Ticket mentions adding a job to delete old entries but also mentions we might keep these around)
|
|
||
| if test_version == "mann-whitney-u": | ||
| json_safe_data = json.loads(json.dumps(serialized_data, cls=DecimalEncoder)) | ||
| PerfCompareMwuCache.objects.create(hash_key=cache_key, results=json_safe_data) |
Collaborator
There was a problem hiding this comment.
get_or_create is safer in case two requests race for the same key
| first_response = client.get(reverse("perfcompare-results") + query_params) | ||
| assert first_response.status_code == 200 | ||
| assert PerfCompareMwuCache.objects.count() == 1 | ||
| _first_cache_key = PerfCompareMwuCache.objects.first().hash_key |
Collaborator
There was a problem hiding this comment.
_first_cache_key is assigned but never read
| @@ -1292,6 +1296,27 @@ def list(self, request): | |||
|
|
|||
| # Process results based on test version | |||
| if test_version == "mann-whitney-u": | |||
Collaborator
There was a problem hiding this comment.
nit: Initialize cache_key to None before the if block:
Suggested change
| if test_version == "mann-whitney-u": | |
| cache_key = None | |
| if test_version == "mann-whitney-u": |
| extra_options = "e10s fission stylo webrender" | ||
| measurement_unit = "ms" | ||
|
|
||
| base_sig = create_signature( |
Collaborator
There was a problem hiding this comment.
All three new tests repeat the same ~50-line block of setup: creating base_sig, new_sig, populating PerformanceDatum rows.
nit: To reduce duplication, we could move this setup logic into a common helper or a pytest fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add caching of results to backend of perfcompare API