Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query.any() and Query.all() put the sub-query into their cache key, but an uncacheable sub-query (for example one using a callable in its path via map()) has no hash of its own, so every such sub-query compares equal. Two searches like where('val').any(where('x').map(f) == 1) and where('val').any(where('x').map(f) == 5) therefore shared one cache entry, and the second search returned the first one's documents.
any() and all() are now uncacheable when the condition they are given is uncacheable, the same way & and | already behave. The new test in test_tables.py runs both queries against a table and checks that each returns its own documents and that nothing ends up in the query cache.