Repository navigation
Add opt-in FailFast processor for object field errors - #744
Merged
liuzicheng1987 merged 1 commit intoOct 18, 2026
Merged
liuzicheng1987 merged 1 commit into
liuzicheng1987 merged 1 commit into
Conversation
Collaborator
|
@Altren OK, this one looks good to me. I will merge it. Thank you for the contribution. |
liuzicheng1987
merged commit Oct 18, 2026
a0ab524
into
munich-data-engineering:main
176 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: Turned out that main performance gains are applicable in top of #743 , and without it the gain is small. And overall default non-FailFast version is slower with GCC+noLTO
Add an opt-in
rfl::FailFastprocessor for callers that only need the first object-field error. It skips decoding later fields of that object after a failure, including nested structs and named tuples, while retaining cleanup of already-constructed fields.Together with #743 FailFast option makes YAS reader 2x faster and much closer to raw serialization implementation without reflect-cpp. This change unlocks more agressive compiler optimizationf for both no-LTO and LTO builds.