Skip to content

fix(achtransfer): add confirmation_id to AchTransfer - #381

Merged
kydav merged 3 commits into
masterfrom
feature/adding-confirmation-id-ach-transfer
Aug 12, 2026
Merged

fix(achtransfer): add confirmation_id to AchTransfer#381
kydav merged 3 commits into
masterfrom
feature/adding-confirmation-id-ach-transfer

Conversation

@kydav

@kydav kydav commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

Adds confirmationId to the AchTransfer model to support returning a confirmation ID that matches the id field from GCU Path.

Fixes # (issue)

Public API Additions/Changes

Added confirmationId (String) field to AchTransfer.

Downstream Consumer Impact

Non-breaking addition. Downstream consumers will have access to a new confirmation_id field on ACH transfer responses. No migration required.

How Has This Been Tested?

No new tests required — field addition follows existing model conventions and no masking logic applies.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Adds `confirmationId` to the `AchTransfer` model to support returning a confirmation ID that matches
the id field from GCU Path.
gerfboy
gerfboy previously approved these changes Aug 12, 2026
Adds `confirmationId` to the `AchTransfer` model to support returning a confirmation ID that matches
the id field from GCU Path.
@gitguardian

gitguardian Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
23397149 Triggered Generic High Entropy Secret 0f7f8f8 mdx-models/src/test/groovy/com/mx/path/model/mdx/model/MdxLogMaskerTest.groovy View secret
23397147 Triggered Generic Password 0f7f8f8 mdx-models/src/test/groovy/com/mx/path/model/mdx/model/MdxLogMaskerTest.groovy View secret
23397141 Triggered Generic High Entropy Secret 0f7f8f8 mdx-models/src/test/groovy/com/mx/path/model/mdx/model/MdxLogMaskerTest.groovy View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@kydav
kydav merged commit db25563 into master Aug 12, 2026
9 of 11 checks passed
@kydav
kydav deleted the feature/adding-confirmation-id-ach-transfer branch August 12, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants