Skip to content

fix: add recurringP2PTransferId to P2PTransfer - #385

Open
tylerGroesbeckMx wants to merge 1 commit into
masterfrom
tyler/GCU-1431
Open

fix: add recurringP2PTransferId to P2PTransfer#385
tylerGroesbeckMx wants to merge 1 commit into
masterfrom
tyler/GCU-1431

Conversation

@tylerGroesbeckMx

@tylerGroesbeckMx tylerGroesbeckMx commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Mobile core added recurring_p2p_transfer_id field to P2P Transfers and it needs to be added to path-model

path-model: https://github.com/mxenabled/path-mdx-model/blob/master/mdx-models/src/main/java/com/mx/path/model/mdx/model/p2p_transfer/P2PTransfer.java

spec: https://developer.mx.com/drafts/mdx/p2p_transfer/index.html#changes-rev-1-2025-10-22

Fixes # https://mxcom.atlassian.net/browse/GCU-1431

Public API Additions/Changes

P2PTransfer now has an additional field: recurringP2PTransferId

Downstream Consumer Impact

This is just adding a field to an existing model so it shouldn't have a large impact.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Project builds successfully
  • Asked Claude code to check project for any issues with field addition and none were found
  • Published local snapshot and tested serialization. Response is working as expected:
GET http://localhost:3009/globalcu/users/U-00u3la36x0bbNvPud1d7/p2p_transfers/6902253

HTTP/1.1 200 
Content-Type: application/vnd.mx.mdx.v6+json;charset=UTF-8
Content-Length: 111
Date: Fri, 14 Aug 2026 21:45:03 GMT

{
  "p2p_transfer": {
    "recurring_p2p_transfer_id": "6902253",
    "user_id": "U-00u3la36x0bbNvPud1d7"
  }
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@stevecl5

Copy link
Copy Markdown
Contributor

@tylerGroesbeckMx Please fill out the "How Has This Been Tested?" and "Checklist" sections in the MR template.

private String recipientId;
private String recipientVerificationAnswer;
private String recipientVerificationQuestion;
private String recurringP2PTransferId;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should confirm that is is getting serialized to recurring_p2p_transfer_id as expected. Can you pull a snapshot version with this change into a path connector, populate the value, and provide an example response?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good call, cause it ended up looking like this:

{
  "p2p_transfer": {
    "recurring_p2_p_transfer_id": "6902253",
    "user_id": "U-00u3la36x0bbNvPud1d7"
  }
}

That second p needs to be lowercased or I can annotate it. Pushing a fix now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we annotate it with @SerializedName instead? We are pretty consistent with capitalizing P2P in class and variable names elsewhere, so this would be a good use of an annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants