Repository navigation
Update NetGraph integration and Superset setup - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a98549dcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lared dependencies Keep the changelog under Unreleased and the version at 0.3.0. Drop the links, parameters and tm_placement fallbacks, pass the step name to latency metrics, run the TopoGen pipeline checks in the default suite, and rebuild fixtures with ngraph 0.23.1, netgraph-core 0.10.0 and TopoGen 5f7cbbe. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…paths README covers run, build, metrics, test and autoresearch and installs from Git; the PyPI name belongs to another project. The DSL reference loads from the .claude/skills submodule, which workspace setup checks out. Drop the publish workflow and Makefile targets, eager submodule imports in netlab/__init__.py, and add project URLs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…kage Fixtures come from ngraph 0.24.0 and netgraph-core 0.10.0 on PyPI with TopoGen f06f563; metric values are unchanged and the removed active_seed and acceptance_rule fields are gone from the results. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align NetLab with NetGraph 0.24.0 scenarios and results, and add isolated Superset workspace setup. Fix directional BAC and iteration plots, regenerate simulation fixtures, and simplify documentation.
Follow-up on the first revision:
[Unreleased], released sections untouched, package version stays0.3.0until release.linksgraph key in the DC-BB experiment,parametershypothesis-template alias,tm_placementfallback in sweeps) and the step-renaming adapter for latency metrics.ngraph>=0.24.0. Fixtures regenerated from the declared dependencies:ngraph==0.24.0andnetgraph-core==0.10.0from PyPI, TopoGenf06f563(main). Metric values are unchanged;tests/data/README.mdrecords the provenance anddev/regenerate_fixtures.pyreproduces them.Documentation and housekeeping:
run,build,metrics,test,autoresearch) and the Git-based install; the previouspip install netlabpointed at an unrelated PyPI project..claude/skillssubmodule instead of hard-coded personal paths; workspace setup and the clone instructions check it out.netlab/__init__.py, added project URLs.Validation: lint and type checks clean; full suite including the five pipeline checks passes in a fresh Python 3.13 environment installed from
pyproject.toml(ngraph 0.24.0, TopoGen main). All experiment and debug scenarios passngraph inspecton 0.24.0.🤖 Generated with Claude Code