Repository navigation
Integrate TopoGen APIs and simplify NetLab execution - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0933d1166
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| capture_output=True, | ||
| text=True, | ||
| timeout=timeout_s, | ||
| errors = validate_scenario_file(scenario_path, expected) |
There was a problem hiding this comment.
For netlab autoresearch sweep and cross-sweep, this call expands the full generated topology synchronously via Scenario.from_yaml, outside the timed worker used by run_simulation. A large or pathological scenario can therefore exceed --timeout indefinitely before the timed simulation is even submitted, whereas the previous inspect subprocess applied timeout_s; run this validation in the task queue with the configured deadline or reuse the worker's timed parse.
Useful? React with 👍 / 👎.
1 participant
Run TopoGen and NetGraph through Python APIs and a local task queue, with enforced timeouts and verified result caches.
Correct bandwidth availability, latency references, and paired-seed comparisons. Publish complete metric reports only after successful analysis. Research uses the same execution API, with corrected ranking and resume checks.
Breaking changes: metrics move to
netlab.metrics; executable overrides and legacy schemas are removed. SeeCHANGELOG.mdfor details.Validation: GitHub CI passed on Python 3.11–3.13 (517 tests each), all pre-commit hooks passed, and wheel/sdist checks passed. Independent metric verification covers 38 native runs and 435 multi-seed failure trials.