Repository navigation
MetadataSource: publisher_page, for a licence a held copy's publisher page states - #46
Merged
Merged
Conversation
An HTML copy read from the publisher's site (ingestion's ACE pages) states its own rights in dc.rights or prism.copyright metadata, or in the copyright line it prints. No MetadataSource value names that source, so a licence read there cannot say who stated it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ce in its description The example carries the sa-user-license line of an ACE-scraped ScienceDirect page (PMID 32664016), so dropping publisher_page from the enum fails the suite. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…cess unrecorded The page says openaccessArticle false and entitlementReason subscription, and its sa-start-date is 12 months after the 2020-06-04 version of record, so the self-archiving licence covers the accepted manuscript. ACE copies have access unrecorded. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jdkent
marked this pull request as ready for review
October 18, 2026 22:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds one
MetadataSourcevalue,publisher_page: a held copy's web page at its publisher. ALicenseread from that page needs a source to name asstated_by, and none of the existing values fits it.Why
Ingestion holds a copy of many papers only as the publisher's HTML page (its "ACE" download). Today none of these pages is read for a licence.
In ingestion's census of 5,200 synced articles, 1,341 ACE copies were recorded as assumed all rights reserved. The page itself usually states the rights:
dc.rightsorprism.copyrightmeta tag, or acopyright-statementorcopyright-lineelement. Some examples:sa-user-license, Elsevier's licence for the accepted manuscript.These are stated licences, so they should be recorded as stated, not assumed. The existing values each name another source:
jatselsevierpmc_cloudWhat changed
license.yaml: the newpublisher_pagevalue.No schema version bump: this adds one permissible value, and nothing that validated before stops validating. If you would rather bump it, the examples'
schema_versionand ingestion's upload cassettes move with it.Tests
python tools/generate_models.py --checkpasses, andpytestpasses (1 skipped: building a wheel needs setuptools).Follow-up
Once this merges, ingestion moves its pin to main and reads each ACE page's own rights, stated by
publisher_page.🤖 Generated with Claude Code