Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some monitors return a capabilities string with a missing closing parenthesis in
vcp(...)orcmds(...). For example, the LEMON25 reports... 62 87 8D CC mccs_ver(2.2)mswhql(1)), causing the parser to interpretmccs_veras a hexadecimal VCP code and raiseValueError.Stop numeric capability extraction at the next named field at the list's outer level. This preserves the supported codes, input sources, color presets, and metadata while keeping nested hexadecimal value lists intact.
Regression tests cover the exact LEMON25 response, its correctly closed equivalent, missing closures in both numeric lists, and nested values. Invalid numeric tokens still raise an error.
Validation: 136 tests passed; Ruff lint, formatting, and
git diff --checkpassed.