Repository navigation
feat(shares): allow to configure expiration date of shares - #2889
Merged
Merged
Conversation
5 tasks
mejo-
force-pushed
the
feat/share_expiry_date
branch
5 times, most recently
from
October 22, 2026 08:17
e4ef5a8 to
da0c246
Compare
mejo-
force-pushed
the
feat/share_expiry_date
branch
from
November 2, 2026 11:47
da0c246 to
ac33292
Compare
* Return the expiration date of the underlying link share, including the server default or enforced date applied on share creation. * Allow to set, change and remove the expiration date via the update share API. Dates are parsed in the user's timezone, and the date is only updated if it changed, to not re-validate unchanged dates against the server policy. * Return expiration date policy errors from the share manager as 400 responses instead of 500. * Add an expiration date picker to the advanced share settings, respecting the default and enforced expiration date policy of the server. Fixes: #1566 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
Setting app config with occ doesn't clear the web server's app config cache. On server master, requests that started before the change can write old values back to that cache, which made the enforced password share test fail when it waited for the changed capabilities. Set the config via the provisioning API instead, which clears the cache. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
feat/share_expiry_date
branch
from
November 2, 2026 11:48
ac33292 to
5abe2fc
Compare
benjaminfrueh
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1566
Assisted-by: ClaudeCode:claude-opus-5-5
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)