Skip to content

feat(shares): allow to configure expiration date of shares - #2889

Merged
mejo- merged 2 commits into
mainfrom
feat/share_expiry_date
Nov 2, 2026
Merged

mejo- merged 2 commits into
mainfrom
feat/share_expiry_date

Conversation

@mejo-

@mejo- mejo- commented Oct 21, 2026 •

Copy link
Copy Markdown
Member
  • Return the expiration date of the underlying link share, including the server default or enforced date applied on share creation.
  • Allow to set, change and remove the expiration date via the update share API. Dates are parsed in the user's timezone, and the date is only updated if it changed, to not re-validate unchanged dates against the server policy.
  • Return expiration date policy errors from the share manager as 400 responses instead of 500.
  • Add an expiration date picker to the advanced share settings, respecting the default and enforced expiration date policy of the server.

Fixes: #1566

Assisted-by: ClaudeCode:claude-opus-5-5

🖼️ Screenshots

🏚️ Before 🏡 After
x grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Oct 21, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Oct 21, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Oct 21, 2026
@mejo-
mejo- force-pushed the feat/share_expiry_date branch 5 times, most recently from e4ef5a8 to da0c246 Compare October 22, 2026 08:17
Comment thread lib/Service/CollectiveShareService.php Resolved
@mejo-
mejo- force-pushed the feat/share_expiry_date branch from da0c246 to ac33292 Compare November 2, 2026 11:47
mejo- added 2 commits November 2, 2026 12:47
* Return the expiration date of the underlying link share, including
  the server default or enforced date applied on share creation.
* Allow to set, change and remove the expiration date via the update
  share API. Dates are parsed in the user's timezone, and the date is
  only updated if it changed, to not re-validate unchanged dates
  against the server policy.
* Return expiration date policy errors from the share manager as
  400 responses instead of 500.
* Add an expiration date picker to the advanced share settings,
  respecting the default and enforced expiration date policy of the
  server.

Fixes: #1566

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
Setting app config with occ doesn't clear the web server's app config
cache. On server master, requests that started before the change can
write old values back to that cache, which made the enforced password
share test fail when it waited for the changed capabilities. Set the
config via the provisioning API instead, which clears the cache.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the feat/share_expiry_date branch from ac33292 to 5abe2fc Compare November 2, 2026 11:48
@mejo-
mejo- requested a review from benjaminfrueh November 2, 2026 11:48
@mejo-
mejo- merged commit 618c4ea into main Nov 2, 2026
64 checks passed
@mejo-
mejo- deleted the feat/share_expiry_date branch November 2, 2026 13:31
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Public shares inherit default expiry date from file shares

2 participants