Skip to content

fix: several issues related to attachments - #2914

Merged
mejo- merged 4 commits into
mainfrom
fix/attachments_path
Nov 3, 2026
Merged

mejo- merged 4 commits into
mainfrom
fix/attachments_path

Conversation

@mejo-

@mejo- mejo- commented Nov 3, 2026

Copy link
Copy Markdown
Member

📝 Summary

See commit messages for details.

  • fix(attachments): return collective-relative path after upload and rename
  • fix(attachments): make restoreAttachment() return a proper attachment entry
  • fix(pageTrash): fix trash backend's restore conflict renaming
  • fix(attachments): fix previews and links in sidebar for public shares

Fixes: #2900

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Nov 3, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 3, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 3, 2026
@mejo-
mejo- enabled auto-merge (rebase) November 3, 2026 13:50
mejo- added 4 commits November 3, 2026 15:29
…name

Uploads via attachments tab returned a wrong attachment path in some
scenarios.

Fixes partially: #2900

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
… entry

Also use the response in frontend so a rename due to naming conflict is
reflected.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
In case the restored file got renamed due to a conflict, e.g.
'Page/.attachments.5/a.png' turned into 'Page/.attachments.5a (1)png'.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
Fixes partly: #2900

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the fix/attachments_path branch from 2c5b66e to 5b0d218 Compare November 3, 2026 14:33
@mejo-
mejo- merged commit 1961ccd into main Nov 3, 2026
64 checks passed
@mejo-
mejo- deleted the fix/attachments_path branch November 3, 2026 19:55
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

share link not work for media

2 participants