Skip to content

fix(push): don't listen to notify_push in public shares - #2915

Merged
mejo- merged 1 commit into
mainfrom
fix/share_no_notify_push
Nov 3, 2026
Merged

mejo- merged 1 commit into
mainfrom
fix/share_no_notify_push

Conversation

@mejo-

@mejo- mejo- commented Nov 3, 2026

Copy link
Copy Markdown
Member

notify_push in Collectives requires a logged in user anyway (we notify only logged in users that registered as session). Registering notify_push in public shares resulted in superfluous POST requests and slowed down page list updates.

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

notify_push in Collectives requires a logged in user anyway (we notify
only logged in users that registered as session). Registering
notify_push in public shares resulted in superfluous POST requests and
slowed down page list updates.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Nov 3, 2026
@mejo- mejo- added the bug Something isn't working label Nov 3, 2026
@mejo-
mejo- requested a review from max-nextcloud as a code owner November 3, 2026 13:50
@mejo-
mejo- requested a review from silverkszlo as a code owner November 3, 2026 13:50
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 3, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 3, 2026
@mejo-
mejo- merged commit 28bd1a9 into main Nov 3, 2026
62 checks passed
@mejo-
mejo- deleted the fix/share_no_notify_push branch November 3, 2026 16:49
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants