Repository navigation
Conversation
juliusknorr
approved these changes
Oct 15, 2026
juliusknorr
reviewed
Oct 15, 2026
| return $value; | ||
| } | ||
| } catch (\Throwable $e) { | ||
| $this->logger->warning('Could not read cached remote data for ' . $this->cacheKey, ['exception' => $e]); |
Member
There was a problem hiding this comment.
I was thinking about writing null to the cache here to prevent this triggering over and over again, but think this would then prevent quick recovery if the file is written again.
May be worth to double check but not a blocker from my POV.
Collaborator
Author
There was a problem hiding this comment.
I think it's probably better to just keep it as the last state of the file, rather than delete it or write null to it
elzody
force-pushed
the
fix/cached-request-unreadable-appdata
branch
from
October 20, 2026 00:01
a62e912 to
d7fc7d8
Compare
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/cached-request-unreadable-appdata
branch
from
October 20, 2026 00:03
d7fc7d8 to
f6114ab
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6174
If something cached in appdata like discovery XML is unreadable, it causes a 500 Internal Server Error on the instance, but ideally we want to prevent that and handle it accordingly.