Repository navigation
[stable33] fix(templates): handle upload errors properly - #6207
Merged
Merged
Conversation
When trying to upload a global template that failed (e.g. file was too large), it would try to detect the MIME type of the file even if it didn't exist, causing a 500 Internal Server Error response. Instead, we should check for errors first, and then try to detect the MIME type only after we know there are no errors. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Distinguish between an upload that failed and an upload that simply contained nothing Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
backportbot
Bot
added
bug
On stable33 the @nextcloud/dialogs library is on v6, but the test assertions were done with v7 in mind on main. So they need to be adjusted to correctly identify the toast message and assert that the content matches Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev> Assisted-by: ClaudeCode:claude-opus-5
elzody
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6076