Repository navigation
feat(contexts): nest menu items one level deep - #3137
rubenvdlinde wants to merge 2 commits into
Conversation
6540b64 to
b167dd6
Compare
090ac9c to
14a341b
Compare
14a341b to
28a56c3
Compare
b167dd6 to
85b998e
Compare
28a56c3 to
a994451
Compare
9247115 to
b99771d
Compare
70eda55 to
065c9b9
Compare
Oh, my bad. Now I see it in one of your images. I would have to think about it then, i didn't notice earlier |
065c9b9 to
de11d95
Compare
3593dbc to
9c7797a
Compare
de11d95 to
06745a2
Compare
Co-authored-by: remko48 <remko@conduction.nl> Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ruben van der Linde <ruben@conduction.nl>
9c7797a to
eb6d3f4
Compare
06745a2 to
64c061c
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Part of #3099, on top of #3136 (menu saving). A menu item can sit under another item, one level deep, for example a few views under the table they belong to. This replaces #3088 by @remko48.
Size: 248 lines: 100 code, 128 tests and 20 generated OpenAPI.
What changes
parentIndex). Nesting goes one level deep: a parent can't have a parent of its own.parentId.How it was tested
On Nextcloud 34 with PostgreSQL:
MenuItemInputTest(40 tests),ContextServiceTest(50 tests) andContextControllerTestcomposer cs:check, psalm and rector, all clean🖼️ Screenshots
Backend only, no UI changes.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)