Repository navigation
fix: qualify native RealityScan and Postshot report imports - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Postshot 1.1.69 camera exports start image and camera IDs at zero, so the importer rejected the real staircase reports. Accept valid unsigned COLMAP IDs in text and binary exports, scope appended Postshot logs before UTF-8 decoding, and apply the Studio dark theme to the consumer report dialog.
Qualification reopens the retained RealityScan 2.2 and Postshot projects without rerunning reconstruction. The report records per-component capture/direction coverage, identical Postshot text/binary membership (118/186), and the correspondence between five mask warnings and five absent Down views. Failed projects without camera poses retain unknown coverage.
Validation: 521 tests and 20 subtests passed without skips; all 33 importer tests passed again after BOM handling was preserved. Ruff, whole-project and critical-contract mypy, release metadata and whitespace checks passed. Five native reports were imported, saved and reopened in macOS Studio; this does not qualify distributed binaries, Windows Studio or CUDA. Public evidence contains compact measurements; private native files and media are excluded.