Skip to content

ci: ignore sourceware.org for markdown link checks - #2577

Open
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:ignore-sourceware-org
Open

ci: ignore sourceware.org for markdown link checks#2577
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:ignore-sourceware-org

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

In markdown_link_check_config.json

Motivation and Context

The workflow .github/workflows/markdown-link-check.yml is sporadically failing with Status 0 errors:

  [✖] https://sourceware.org/glibc/ → Status: 0

See workflow logs

The following manually executed command is succeeding, although it is very slow:

curl -I https://sourceware.org/glibc/

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399 MikeMcC399 added the ci CI (Continuous Integration) workflows label Jul 23, 2026
@MikeMcC399 MikeMcC399 self-assigned this Jul 23, 2026
@MikeMcC399
MikeMcC399 marked this pull request as ready for review July 23, 2026 11:23
@MikeMcC399
MikeMcC399 requested a review from nschonni July 23, 2026 11:24
@MikeMcC399
MikeMcC399 requested a review from sxa July 28, 2026 08:39
@MikeMcC399

Copy link
Copy Markdown
Contributor Author

@nschonni

Could you possibly review this one, as the link checking is flaky, causing the whole workflow to show failure.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the markdown link checker configuration to ignore sourceware.org URLs, avoiding sporadic CI failures caused by Status: 0 responses when validating links to the glibc site.

Changes:

  • Add an ignorePatterns entry for ^https://sourceware\.org/ in markdown_link_check_config.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nschonni

Copy link
Copy Markdown
Member

I think it's better to replace/remove a flaky link, rather than ignoring it

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

I think it's better to replace/remove a flaky link, rather than ignoring it

It's only flaky when it's tested with markdown-link-check. It's difficult to know for sure in any particular case, but some sites have protection against automated link checking.

https://sourceware.org/glibc/ worked perfectly when I accessed it just now in Google Chrome. I don't think we should remove the link itself, and the content was updated a couple of days ago, so it seems to be providing relevant reference content.

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

This was fast today:

$ curl -I https://sourceware.org/glibc/
HTTP/2 200 
server: nginx
date: Wed, 29 Jul 2026 14:22:18 GMT
content-type: text/html; charset=UTF-8
content-length: 5614
last-modified: Mon, 27 Jul 2026 14:40:08 GMT
etag: "15ee-65798b2e6b34f"
accept-ranges: bytes
vary: Accept-Encoding
content-security-policy: default-src 'self' http: https:
strict-transport-security: max-age=16070400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI (Continuous Integration) workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants