build,win: add PGO workload scripts - #63696
Merged
nodejs-github-bot merged 2 commits intoAug 20, 2026
Merged
Conversation
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
StefanStojanovic
added
windows
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Contributor
Author
|
Pinging @nodejs/build for visibility (@nodejs/platform-windows too). |
Contributor
Author
|
Here are the performance improvements calculated based on running the benchmarks from the Node.js repository. https://github.com/JaneaSystems/node-pgo-perf |
richardlau
approved these changes
Aug 18, 2026
richardlau
added
the
commit-queue-squash
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
StefanStojanovic
added
the
commit-queue
Collaborator
|
Landed in 58d58a4 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PGO workload scripts to be used for the PGO-enabled build of Node.js, as well as the wrapper script to run all of the workloads and combine all of the
profrawfiles intoprofdataon Windows. This way, the build becomes a 3-step process:vcbuild.bat pgo-generatepgo.ps1vcbuild.bat pgo-useWhile this was developed primarily for Windows, PGO itself is platform-agnostic, so the workloads should do well on other platforms that support PGO, although some utility scripts for running an instrumented build and getting results should probably be added to make its usage simpler.
I will share the performance differences in the following days, showcasing the improvements with PGO enabled on Windows.
Refs: #61964