src: fix heap value deduplication in embedder graph - #64801
Open
IlyasShabi wants to merge 1 commit into
Open
Conversation
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/embedder-graph-deduplication
branch
from
July 28, 2026 10:09
bc8ffc2 to
d62e941
Compare
IlyasShabi
marked this pull request as ready for review
July 28, 2026 10:17
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64801 +/- ##
==========================================
+ Coverage 90.13% 90.14% +0.01%
==========================================
Files 741 744 +3
Lines 242106 242542 +436
Branches 45551 45692 +141
==========================================
+ Hits 218211 218648 +437
+ Misses 15430 15394 -36
- Partials 8465 8500 +35
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an embedder graph bug introduced by #52295, where distinct V8 values could be treated as the same graph node.
It uses an explicit value lookup for deduplication and extends the internal test binding to expose V8 values for regression testing.