Skip to content

test: add Headers coverage and benchmark - #65365

Open
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a
Open

test: add Headers coverage and benchmark#65365
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:cursor/headers-class-performance-859a

Conversation

@anonrig

@anonrig anonrig commented Aug 18, 2026

Copy link
Copy Markdown
Member

Adds Node-side coverage for the WHATWG Headers API and a fetch/headers benchmark.

These tests are not from WPT. They cover constructor init, get/set/append/delete, set-cookie / getSetCookie(), iteration (including mutation during iteration), validation, brand checks, and util.inspect.

The implementation change lives in undici:

Refs: nodejs/undici#5699

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Aug 18, 2026
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node
can track the API after the implementation change lands in undici.

Refs: nodejs/undici#5699
Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 3ea8120 to eb22154 Compare August 18, 2026 01:59
@anonrig anonrig changed the title deps: improve Headers class performance test: add Headers coverage and benchmark Aug 18, 2026
@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from eb22154 to 2edacb0 Compare August 18, 2026 02:06
@anonrig
anonrig marked this pull request as ready for review August 18, 2026 02:06

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI agents are not permitted to use the Signed-off-by

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (f83e7df) to head (2edacb0).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65365      +/-   ##
==========================================
- Coverage   90.31%   90.14%   -0.18%     
==========================================
  Files         751      752       +1     
  Lines      249956   251884    +1928     
  Branches    47204    47379     +175     
==========================================
+ Hits       225745   227054    +1309     
- Misses      15612    16147     +535     
- Partials     8599     8683      +84     

see 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Commit metadata needs fixing.

@cursor
cursor Bot force-pushed the cursor/headers-class-performance-859a branch from 2edacb0 to 0225f7b Compare August 18, 2026 12:49
@anonrig

anonrig commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Addressed the review feedback:

  • Removed the AI Signed-off-by. The commit is now authored and signed off by Yagiz Nizipli.
  • Fixed the quote-props lint failures in benchmark/fetch/headers.js and test/parallel/test-whatwg-headers.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants