Skip to content

doc: correct QuicStream direction and id types - #66687

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kisnner26:doc/quic-stream-types
Oct 14, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kisnner26:doc/quic-stream-types

Conversation

@kisnner26

@kisnner26 kisnner26 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the documented nullability of QuicStream.direction and clarifies that QuicStream.id is only null while a stream is pending.

Fixes: #66686.

Validated against the current getters and test/parallel/test-quic-session-stream-lifecycle.mjs.

Signed-off-by: Kisnner Obando <kisnnerobando7@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation. labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@MikeMcC399

MikeMcC399 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

If your PR is intended to fix an issue, then include the Fixes: prefix in the PR description.

See Commit message guidelines according to the Pull requests documentation.

Refs: is for other references only.

Edit: I made the change, since this PR has now been approved.

@jasnell jasnell moved this to Ready to Land in QUIC Team Oct 14, 2026
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 14, 2026
@pimterry pimterry added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 4381c47 into nodejs:main Oct 14, 2026
33 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 4381c47

@github-project-automation github-project-automation Bot moved this from Ready to Land to Done in QUIC Team Oct 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:mixed-signals author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. quic Issues and PRs related to the QUIC transport implementation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

doc: QuicStream.direction / id is incorrectly documented as nullable

5 participants