Skip to content

Modify Bitwarden client to handle missing email - #50

Merged
Lujeni merged 2 commits into
numberly:mainfrom
Nemirtingas:feature/login-optional-mail
Jun 2, 2026
Merged

Lujeni merged 2 commits into
numberly:mainfrom
Nemirtingas:feature/login-optional-mail

Conversation

@Nemirtingas

@Nemirtingas Nemirtingas commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

Remove email parameter requirement and fetch email if not provided.

Closes #34

@Lujeni Lujeni self-assigned this May 29, 2026
@Lujeni

Lujeni commented May 29, 2026

Copy link
Copy Markdown
Member

@Nemirtingas thanks for the MR

Can you update the tests pls ?

Remove email parameter requirement and fetch email if not provided.
@Nemirtingas

Copy link
Copy Markdown
Contributor Author

That should do it.

@Lujeni

Lujeni commented May 29, 2026

Copy link
Copy Markdown
Member

@Nemirtingas thanks for the MR

Can you update the tests pls ?

@Nemirtingas Sorry if I wasn't clear, looks like you've fixed the CI/linter thing (good btw:)). My original ask was about adding a unit test though.

@Nemirtingas

Copy link
Copy Markdown
Contributor Author

Well, I don't know. I always get a
httpx.HTTPStatusError: Client error '429 Too Many Requests' for url 'http://127.0.0.1/identity/connect/token'

Any idea why it would send a 429 response?

@Lujeni

Lujeni commented Jun 2, 2026

Copy link
Copy Markdown
Member

Well, I don't know. I always get a httpx.HTTPStatusError: Client error '429 Too Many Requests' for url 'http://127.0.0.1/identity/connect/token'

Any idea why it would send a 429 response?

imo you moved the BitwardenAPIClient creation, so every tests generated new client (and more requests)

@Nemirtingas

Copy link
Copy Markdown
Contributor Author

Ah, yes thanks! That was it. All green now.

@Lujeni
Lujeni merged commit 980d545 into numberly:main Jun 2, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't make mail required because the api credentials are enought.

2 participants