Updates for bit-for-bit fields that interact with RRTMGP - #3
Merged
Conversation
added 8 commits
July 16, 2026 19:36
… pumas_post_main Mirrors CAM micro_pumas_cam post-call recomputation, which discards the per-substep values PUMAS returns. Match dei standard name with RRTMGP and the CAM-SIMA registry (singular crystal). Run pumas_post_main before apply_heating_rate (air density uses the pre-heating temperature) and add the low stratiform cloud fraction optics limiter to the suite.
Mirrors CAM micro_pumas_cam, including the separate meters-to-microns conversion step. Match snow diameter standard name with RRTMGP and the CAM-SIMA registry (snow_crystal).
cacraigucar
approved these changes
Jul 20, 2026
cacraigucar
left a comment
cacraigucar
left a comment
Collaborator
There was a problem hiding this comment.
Blindly accepting - will uncover any issues during testing (but do not expect to find any)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields weren't checked by the physics data checker because their standard names weren't matching the ones in the registry, but now they are checked.
Assisted-by: claude-fable:5 who helped find and extract the relevant parts of the code from
micro_pumas_cam.F90to resolve the bfb issues.