Repository navigation
Dr.Egeria Postgres element commands take a secrets store (ISSUE-160 follow-up) - #478
Merged
Merged
Conversation
…ollow-up) pyegeria 6.2.8's Postgres template builders ignore db_user/db_pwd (Egeria's Postgres templates read credentials from a secrets store), but Dr.Egeria's Create Postgres Server Element / Create Postgres Database Element still asked for Database User Id / Database Password and passed them through. - Asset Maker compact spec (edited through the Spec Editor API): delete Database User Id / Database Password (used by no other command); add Secrets Store Path Name and Secrets Collection Name; add Version Identifier to both commands and Resource Name (canonical Governance Officer definition) to the server. - AssetMakerProcessor passes secrets_store_path_name, secrets_collection_name, version (and resource_name for the server), and no longer passes db_user/db_pwd. - Regenerated templates and report specs (refresh_specs --merge-reports). generated_format_sets.json also picks up the analytic_binders field added to ActionParameter since it was last regenerated. - tests/micro-tests/test_postgres_element_secrets.py. - PYEGERIA_ISSUES.md: ISSUE-160's Dr.Egeria follow-up is done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
that referenced
this pull request
Oct 22, 2026
Ships #477 (ISSUE-161: Dr.Egeria entry points resolve the Egeria user at run time with one precedence chain, via resolve_egeria_credentials) and #478 (Dr.Egeria Postgres Server/Database Element commands take secrets-store attributes; Database User Id / Database Password removed). Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISSUE-160 follow-up: pyegeria 6.2.8's Postgres template builders ignore
db_user/db_pwd(Egeria's Postgres templates take credentials from a secrets store), but Dr.Egeria'sCreate Postgres Server Element/Create Postgres Database Elementstill asked for Database User Id / Database Password.AssetMakerProcessorpassessecrets_store_path_name,secrets_collection_name,version(andresource_namefor the server); no longer passesdb_user/db_pwd.refresh_specs --merge-reports).generated_format_sets.jsonalso picks up theanalytic_bindersfield added toActionParametersince its last regeneration.tests/micro-tests/test_postgres_element_secrets.py; ISSUE-160 entry inPYEGERIA_ISSUES.mdupdated.Pairs with #477 for the next release (6.2.9).
Companion template PRs: egeria-workspaces and egeria-trellis
feat/postgres-secrets-templates.Test plan
🤖 Generated with Claude Code