Repository navigation
Dr.Egeria updates no longer reset properties the document doesn't set (ISSUE-162) - #482
Merged
dwolfson merged 3 commits intoOct 23, 2026
Merged
Conversation
…s to False Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…t set (ISSUE-162) Update Glossary Term sent isAbstractConcept/isActivityDescription/ isContext/isDataValue = False whenever the document omitted them, and Update Data Value Specification / Data Class sent allowsDuplicateValues / isNullable = True plus empty lists/maps/0 for matchPropertyNames, matchThreshold, specificationDetails, sampleValues, dataPatterns and additionalProperties. Merge updates dropped only None, so these overwrote existing values. They now default to None (omitted on a merge update, which Egeria defaults to); the old defaults are applied only on Create, so creation is unchanged. Micro-tests: tests/micro-tests/test_issue_162_update_does_not_reset_properties.py (update cases fail on the old code). Full micro-test suite passes in a clean python:3.13-slim container. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…properties) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
to dwolfson/egeria-python
that referenced
this pull request
Oct 23, 2026
…lass-names Resolved the only conflict, PYEGERIA_ISSUES.md: both PRs inserted entries at the top of "Open pyegeria items". Kept both, newest first: ISSUE-165, 164, 163, then 162. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE-162 (PYEGERIA_ISSUES.md; the entry is added in this PR): Dr.Egeria updates reset properties the document didn't mention.
Problem
Merge updates (Egeria's default) drop only
Nonevalues, so any property with a non-Nonedefault was sent on every update and overwrote Egeria's existing value:isAbstractConcept,isActivityDescription,isContextandisDataValueasFalse. A term with any of these set lost it on an unrelated update. Found by Resource Explorer while preparing a 96-term update batch.allowsDuplicateValuesandisNullableasTrue,matchPropertyNames,sampleValuesanddataPatternsas[],matchThresholdas0, andspecificationDetailsandadditionalPropertiesas{}.Change
None, so a merge update leaves them out unless the document sets them. Egeria'smergeUpdatedefaults totrue, so the existing values are kept._with_create_defaultsinmd_processing/v2/data_designer.py, and the term flags inmd_processing/v2/glossary.py), so creation behaves as before.Testing
tests/micro-tests/test_issue_162_update_does_not_reset_properties.py: 7 cases. The 4 update cases fail on the old code; the 3 create cases check the create defaults are unchanged.python:3.13-slimcontainer with no Egeria.🤖 Generated with Claude Code