Skip to content

fix(playground): handle trailing newlines correctly #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohnishant wants to merge 2 commits into from
Closed

fix(playground): handle trailing newlines correctly #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af948d
fix(playground): insert one newline per Enter
ohnishant Aug 29, 2026
bcdda29
fix(playground): allow clearing the empty editor
ohnishant Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions web/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,15 @@ function makeEmoteImg(name) {

// Plain-text source; images contribute their literal names.
function editorSource(root = editor) {
if (root === editor && root.childNodes.length === 1) {
const only = root.firstChild;
if (only.nodeName === "BR" ||
(only.nodeName === "DIV" && only.childNodes.length === 1 &&
only.firstChild.nodeName === "BR")) {
return "";
}
}

let src = "";
for (const node of root.childNodes) {
if (node.nodeType === Node.TEXT_NODE) {
Expand Down Expand Up @@ -212,6 +221,14 @@ function getCaretOffset() {
return count;
}

function sourceOffsetAt(node, offset) {
if (node !== editor && !editor.contains(node)) return null;
const range = document.createRange();
range.setStart(editor, 0);
range.setEnd(node, offset);
return editorSource(range.cloneContents()).length;
}

function setCaretOffset(offset) {
const boundaries = []; // {at, make}
const walk = (node, base) => {
Expand Down Expand Up @@ -619,6 +636,24 @@ editor.addEventListener("keydown", (e) => {
return;
}

if (e.key === "Enter" && !e.ctrlKey && !e.metaKey) {
e.preventDefault();
const sel = getSelection();
if (!sel.rangeCount) return;
const range = sel.getRangeAt(0);
const start = sourceOffsetAt(range.startContainer, range.startOffset);
const end = sourceOffsetAt(range.endContainer, range.endOffset);
if (start === null || end === null) return;
const src = editorSource(editor);
const next = src.slice(0, start) + "\n" + src.slice(end);
editor.replaceChildren(buildEditorFragment(next));
setCaretOffset(start + 1);
renderGutter(next);
scheduleUndoCommit();
updateAutocomplete();
return;
}

if (e.key === "Tab") {
// No popup yet: complete directly when there is exactly one
// candidate, otherwise open the popup for the word at the caret.
Expand Down
Loading