Repository navigation
fix(release): resolve Windows assets by canonical binary name - #49
Merged
Merged
Conversation
Contributor
Author
TDD assessment — PR #49Major
The existing direct test does cover the reported cfl fixture shape ( |
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 446715fe42b0
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-release | 0 |
| policies:conventions | 0 |
Reviewer Coverage
automation:ci-release— complete (broad); skipped: none; constraints: Review limited to the assigned CI/release workflow, composite action, resolver, and fixtures.policies:conventions— complete (broad); inspected 5 assigned files (7 inspected across reviewers):.github/workflows/release.yml,.github/workflows/test-actions.yml,actions/release-assets/action.yml,actions/release-assets/resolve.sh,actions/release-assets/test_resolve.sh; skipped: none; constraints: Shared cli-common convention documents were not available locally or in the supplied review context; review is limited to repository-visible conventions and assigned changes.
Inspected files (7)
.github/workflows/release.yml.github/workflows/test-actions.ymlactions/release-assets/action.ymlactions/release-assets/resolve.shactions/release-assets/test_resolve.shactions/release-assets/testdata/artifacts.jsonactions/release-assets/testdata/metadata.json
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 15s | gpt-5.6-terra | cr 0.10.314
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | automation:ci-release, policies:conventions |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 15s wall · 1m 36s compute |
| Cost | unavailable |
| Tokens | 342.5k in / 4.2k out |
Per-workstream usage
orchestrator-selection— gpt-5.6-terra- In: 33.6k
- Out: 463
- Cache read: 29.2k
- Cache create: unavailable
- Cost: unavailable
- Duration: 12s
automation:ci-release— gpt-5.6-terra- In: 120.5k
- Out: 1.6k
- Cache read: 90.1k
- Cache create: unavailable
- Cost: unavailable
- Duration: 35s
policies:conventions— gpt-5.6-terra- In: 135.1k
- Out: 1.6k
- Cache read: 108.3k
- Cache create: unavailable
- Cost: unavailable
- Duration: 43s
orchestrator-rollup— gpt-5.6-terra- In: 53.3k
- Out: 499
- Cache read: 45.3k
- Cache create: unavailable
- Cost: unavailable
- Duration: 3s
piekstra
added a commit
to open-cli-collective/codereview-cli
that referenced
this pull request
Oct 2, 2026
## Summary Update only the reusable release workflow pin to `776a11fe7a86dccb73bccb5dbf3824fe2ec8d4af`, which includes the merged canonical Windows archive resolver in open-cli-collective/.github#49. The failed v0.10.320 release lists `cr.exe` in each Windows archive's `extra.Binaries`, while the identity manifest declares `cr`. The old resolver returned zero matches and emitted empty matrices, preventing the Windows package jobs from starting. The updated resolver matches both architectures and fails loudly for missing assets. ## Evidence Using the actual `dist` artifact from [the failed release](https://github.com/open-cli-collective/codereview-cli/actions/runs/36931823778): | Resolver | AMD64 | ARM64 | |---|---|---| | Old pinned workflow | zero matches | matrix not produced | | Updated shared action | `cr_v0.10.320_windows_amd64.zip` | `cr_v0.10.320_windows_arm64.zip` | Both Chocolatey and WinGet matrices contain those exact published asset names. The shared resolver regression also verifies missing AMD64 assets fail loudly. Validation: consumer workflow `actionlint` passes; shared resolver, Homebrew modernization/idempotency and alias tests pass; all 28 Chocolatey-push tests pass. The Windows PowerShell renderer was inspected but has not yet run here. The intervening shared changes were inspected: action dependency pins, Homebrew install-step modernization and staged-path correction, and backward-compatible Chocolatey rendering. Existing package templates without URL placeholders keep their legacy path; this does not apply the static-URL migration staged in #634. Package identity, secrets, triggers, production code, and CI pins remain unchanged. The fixture/artifact replay proves matrix resolution, not live Windows package publication. A successful subsequent release is still required. No published tag or asset is changed by this PR; workflow-only changes do not automatically mint a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfl.exewhile identity usescflrelease.ymlechocommand substitutions to be ignoredEvidence
/tmp/cfl-1397-dist/artifacts.json: resolvescfl_1.3.97_windows_amd64.zipandcfl_1.3.97_windows_arm64.zipbash actions/release-assets/test_resolve.shbash -n actions/release-assets/resolve.sh actions/release-assets/test_resolve.shactionlintand YAML parsing passed locallygit diff --checkpassedNo release was triggered and the
@v1pointer was not changed.