Skip to content

fix: render literal Chocolatey download URLs #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rianjs wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: render literal Chocolatey download URLs #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d505f29
fix: render literal Chocolatey download URLs
rianjs Sep 25, 2026
d6e117c
fix: use static Chocolatey renderer in release workflow
rianjs Sep 25, 2026
ffb4fa3
docs: describe Chocolatey URL rendering contract
rianjs Sep 25, 2026
552089d
fix(chocolatey): pin shared release asset resolver
rianjs Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ permissions:

jobs:
release:
uses: open-cli-collective/.github/.github/workflows/release.yml@b6382514b809d960c6fbdc85745a60c14cde04f1 # shared .github
uses: open-cli-collective/.github/.github/workflows/release.yml@776a11fe7a86dccb73bccb5dbf3824fe2ec8d4af # shared .github
with:
# tag push is live (false); workflow_dispatch honors the checkbox. Compare
# against both true and 'true' because a workflow_dispatch boolean input
Expand Down
6 changes: 3 additions & 3 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ shared workflow owns publish mechanics.
`open-cli-collective/homebrew-tap` with `TAP_GITHUB_TOKEN`.
- Chocolatey: the shared Chocolatey job rewrites
`packaging/chocolatey/codereview-cli.nuspec` from version `0.0.0` to the release version
and replaces `CHECKSUM_AMD64_PLACEHOLDER` /
`CHECKSUM_ARM64_PLACEHOLDER` in `chocolateyInstall.ps1` before packing and
pushing.
and replaces `URL_AMD64_PLACEHOLDER`, `URL_ARM64_PLACEHOLDER`,
`CHECKSUM_AMD64_PLACEHOLDER`, and `CHECKSUM_ARM64_PLACEHOLDER` in
`chocolateyInstall.ps1` before packing and pushing.
- winget: the shared winget job resolves the release asset URLs/checksums and
submits `OpenCLICollective.codereview-cli` with `WINGET_GITHUB_TOKEN`;
because this is a first-time package id, `packaging/identity.yml` keeps
Expand Down
13 changes: 6 additions & 7 deletions packaging/chocolatey/tools/chocolateyInstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
$ErrorActionPreference = 'Stop'

$version = $env:ChocolateyPackageVersion
$toolsDir = Split-Path -Parent $MyInvocation.MyCommand.Definition

# Checksums injected by release workflow - DO NOT EDIT MANUALLY
# URLs and checksums injected by release workflow - DO NOT EDIT MANUALLY

@rianjs-bot rianjs-bot Bot Sep 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-release contract is changed to inject both URL placeholders, but docs/development.md still says the shared Chocolatey job replaces only the two checksum placeholders. That repo-local guide is the durable source developers use for release mechanics, so it will send the next maintainer to an incomplete contract and make shared-workflow updates/error diagnosis harder. Update the Chocolatey section to name URL_AMD64_PLACEHOLDER and URL_ARM64_PLACEHOLDER alongside the checksum placeholders.

Reply inline to this comment.

@rianjs rianjs Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ffb4fa3: the development guide now names both URL placeholders and both checksum placeholders in the shared release rendering contract.

$urlAmd64 = 'URL_AMD64_PLACEHOLDER'
$urlArm64 = 'URL_ARM64_PLACEHOLDER'
$checksumAmd64 = 'CHECKSUM_AMD64_PLACEHOLDER'
$checksumArm64 = 'CHECKSUM_ARM64_PLACEHOLDER'

if ($env:PROCESSOR_ARCHITECTURE -eq 'ARM64') {
$arch = 'arm64'
$url = $urlArm64
$checksum = $checksumArm64
} elseif ([Environment]::Is64BitOperatingSystem) {
$arch = 'amd64'
$url = $urlAmd64
$checksum = $checksumAmd64
} else {
throw "32-bit Windows is not supported. cr requires 64-bit Windows."
}

$baseUrl = "https://github.com/open-cli-collective/codereview-cli/releases/download/v${version}"
$zipFile = "cr_v${version}_windows_${arch}.zip"
$url = "${baseUrl}/${zipFile}"

Write-Host "Installing cr ${version} for Windows ${arch}..."
Write-Host "Installing cr for Windows ${arch}..."
Write-Host "URL: ${url}"
Write-Host "Checksum (SHA256): ${checksum}"

Expand Down
10 changes: 4 additions & 6 deletions scripts/verify-package-render.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@ for kind in deb rpm; do
done
done

# Winget and Chocolatey keep version/checksum placeholders in source; the shared
# release workflow substitutes them from the real release assets before publish.
# The generated windows archives above prove the archive naming those templates
# reference is rendered by GoReleaser.
# Winget keeps version/checksum placeholders; Chocolatey keeps URL/checksum
# placeholders. The shared release workflow substitutes them before publish.
require_grep "winget: { id: OpenCLICollective.codereview-cli, bootstrap: true }" "packaging/identity.yml"
require_grep "chocolatey: { id: codereview-cli }" "packaging/identity.yml"

Expand All @@ -81,8 +79,8 @@ require_grep "cr_v0.0.0_windows_arm64.zip" "$winget_installer"
require_file "packaging/chocolatey/codereview-cli.nuspec"
require_file "packaging/chocolatey/tools/chocolateyInstall.ps1"
require_grep "<id>codereview-cli</id>" "packaging/chocolatey/codereview-cli.nuspec"
require_grep 'releases/download/v${version}' "packaging/chocolatey/tools/chocolateyInstall.ps1"
require_grep 'cr_v${version}_windows_${arch}.zip' "packaging/chocolatey/tools/chocolateyInstall.ps1"
require_grep 'URL_AMD64_PLACEHOLDER' "packaging/chocolatey/tools/chocolateyInstall.ps1"
require_grep 'URL_ARM64_PLACEHOLDER' "packaging/chocolatey/tools/chocolateyInstall.ps1"

require_grep 'homebrew-tap-token: ${{ secrets.TAP_GITHUB_TOKEN }}' ".github/workflows/release.yml"
require_grep 'chocolatey-api-key: ${{ secrets.CHOCOLATEY_API_KEY }}' ".github/workflows/release.yml"
Expand Down
Loading