Skip to content

New vulnerability findings data model - #477

Open
ChrisSchneider wants to merge 5 commits into
open-component-model:masterfrom
ChrisSchneider:new-vln-findings-data-model
Open

New vulnerability findings data model#477
ChrisSchneider wants to merge 5 commits into
open-component-model:masterfrom
ChrisSchneider:new-vln-findings-data-model

Conversation

@ChrisSchneider

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Basic compatibility with new data model

Further UI updates are part of open-component-model/open-delivery-gear#186

Which issue(s) this PR fixes:

Fixes open-component-model/open-delivery-gear#187

@ChrisSchneider
ChrisSchneider requested a review from a team as a code owner August 13, 2026 19:16
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ChrisSchneider, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 109 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 71521df9-85df-45ed-8b48-448b813b4bb1

📥 Commits

Reviewing files that changed from the base of the PR and between eb63c53 and a8e8ae2.

📒 Files selected for processing (1)
  • src/rescoring.js

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b9835df3-58db-44da-a7f9-4fee3d4a2c40

📥 Commits

Reviewing files that changed from the base of the PR and between 59baf97 and eb63c53.

📒 Files selected for processing (3)
  • src/ocm/iter.js
  • src/ocm/model.js
  • src/rescoring.js

📝 Walkthrough

Walkthrough

findLabel now supports label aliases. Known label mappings use arrays. Rescoring uses Risk Profile terminology, retains CVE categorisation lookup, and displays updated CVSS and fixed-version data.

Changes

Risk profile and vulnerability updates

Layer / File(s) Summary
Label lookup and metadata support
src/ocm/iter.js, src/ocm/model.js
findLabel accepts one or multiple label names. knownLabelNames uses supported label-name arrays and removes mainSource.
Risk profile label UI
src/rescoring.js
The component and related text use Risk Profile terminology. The lookup still uses knownLabelNames.cveCategorisation.
Vulnerability detail rendering
src/rescoring.js
Details prefer cvss_score, fall back to cvss_v3_score, and show fixed_version when present.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to eb63c

The PR is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Poem

I’m a rabbit reviewing labels with care,
Risk profiles now bloom in the UI air.
CVSS scores hop to the preferred place,
Fixed versions appear when they have a trace.
Aliases join the label parade—
A tidy little change is made.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The changes only update UI compatibility and labels; they do not implement the backend model, utilities, API routes, or scanner selection required by #187. Add or link the required backend implementation, utilities, API routes, and active-scanner handling, or link the PR to the correct UI issue.
Out of Scope Changes check ⚠️ Warning The UI and label changes are not supported by the backend-focused scope of #187, while the description assigns further UI work to #186. Move UI-only changes to issue #186 or document their required dependency on the backend integration in #187.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: compatibility with the new vulnerability findings data model.
Description check ✅ Passed The description states the purpose and linked issue, but omits the special notes and release note sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch new-vln-findings-data-model
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@8R0WNI3 8R0WNI3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the label related changes from this PR.

Comment thread src/rescoring.js
Comment thread src/rescoring.js Outdated
@ChrisSchneider
ChrisSchneider force-pushed the new-vln-findings-data-model branch from 1c47bdb to a7fce29 Compare August 14, 2026 11:35
Signed-off-by: Chris Schneider <chris.schneider02@sap.com>
Signed-off-by: Chris Schneider <chris.schneider02@sap.com>
Signed-off-by: Chris Schneider <chris.schneider02@sap.com>
Signed-off-by: Chris Schneider <chris.schneider02@sap.com>
…new-vln-findings-data-model

Signed-off-by: Chris Schneider <chris.schneider02@sap.com>
@ChrisSchneider
ChrisSchneider force-pushed the new-vln-findings-data-model branch from 74530e8 to a8e8ae2 Compare August 14, 2026 11:45
@ChrisSchneider
ChrisSchneider requested a review from 8R0WNI3 August 14, 2026 11:47
Comment thread src/rescoring.js
</Link>
</Tooltip>
<VulnerabilityExtraInfo vector={finding.cvss} filesystemPaths={finding.filesystem_paths}/>
{finding.cvss && <VulnerabilityExtraInfo vector={finding.cvss} filesystemPaths={finding.filesystem_paths}/>}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is just to make sure that nothing breaks. For broader UI updates there is a separate issue: open-component-model/open-delivery-gear#186

Comment thread src/rescoring.js
<Typography variant='inherit' color={`${categorisationValueToColor(categorisation.value)}.main`}>
{
finding.cvss_v3_score
finding.cvss_score ?? finding.cvss_v3_score

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use cvss_v3_score over cvss_score?

@ChrisSchneider ChrisSchneider Aug 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the other way round? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing

So also when cvss_score is 0, cvss_score would be returned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend integration for new vulnerability data model

3 participants