Repository navigation
Read stream response headers from the stream metadata - #3
Merged
Merged
Conversation
stream_get_meta_data()['wrapper_data'] holds the response header lines on PHP 8.2-8.5, so the streams fallback no longer needs $http_response_header (deprecated in PHP 8.5) or a PHP < 8.4 sidecar class. php -l on 8.5 is clean for the whole package.
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeSsrTransportreads the response headers fromstream_get_meta_data()['wrapper_data']. That works on PHP 8.2–8.5, so the PHP < 8.4 sidecar classLegacyHttpStreamFetchis removed. It was unreleased.$http_response_headerany more.php -lon PHP 8.5 used to flagLegacyHttpStreamFetch.php:25. Now the whole package lints clean on 8.5 (and with opcache preloading too).Unreleasedentry updated.The 0.3 line gets the same change and the
curl_close()removal in #2.Test plan
composer test(57 tests) andcomposer phpstanon PHP 8.2.35 and 8.5.12. This includestest_streams_fallback_reads_status_and_content_typephp -d error_reporting=E_ALL -lis clean for the whole package on 8.2.35, 8.5.4 and 8.5.12composer validate --strict