assign no partition to master thread - #26
Open
AxelSchneewind wants to merge 1 commit into
Open
Conversation
Previously, the partitions were simply assigned to the threads by their respective `thread_num`, assuming numbers between 0 and the thread count. However, as the master thread has `thread_num` of -1, this could result in erroneous assignments, leading to deadlocks in the case of multiple send partitions per receive partition. For this reason, this PR introduces a check that assigns no partitions to the master thread. Signed-off-by: Axel Schneewind <axel.schneewind@hlrs.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the partitions were simply assigned to the threads by their respective
thread_num, assuming numbers between 0 and the thread count. However, as the master thread hasthread_numof -1, this could result in erroneous assignments, leading to deadlocks in the case of multiple send partitions per receive partition.More precisely, if two threads waited for the same partition it was possible that one thread continued to wait while the other had already caused the request to be finalized.
For this reason, this PR introduces a check that assigns no partitions to the master thread.