Skip to content

fix: register current admission webhook subresources #4785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaydipGabani wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: register current admission webhook subresources #4785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921255e
fix: register current admission webhook subresources
JaydipGabani Aug 26, 2026
24c0bc1
Merge branch 'master' into fix/webhook-subresources
JaydipGabani Aug 26, 2026
9c36b81
Merge branch 'master' into fix/webhook-subresources
JaydipGabani Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/build/helmify/replacements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ var replacements = map[string]string{
resources:
- '*'
# Explicitly list all known subresources except "status" (to avoid destabilizing the cluster and increasing load on gatekeeper).
# You can find a rough list of subresources by doing a case-sensitive search in the Kubernetes codebase for 'Subresource("'
# You can find the current list of subresources in the Kubernetes API discovery data.
{{- range .Values.validatingWebhookSubResources }}
- {{ . }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions cmd/build/helmify/static/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ information._
| validatingWebhookCheckIgnoreFailurePolicy | The failurePolicy for the check-ignore-label validating webhook | `Fail` |
| validatingWebhookExemptNamespacesLabels | Additional namespace labels that will be exempt from the validating webhook. Please note that anyone in the cluster capable to manage namespaces will be able to skip all Gatekeeper validation by setting one of these labels for their namespace. | `{}` |
| validatingWebhookCustomRules | Custom rules for selecting which API resources trigger the webhook. Mutually exclusive with `enableDeleteOperations`. NOTE: If you change this, ensure all your constraints are still being enforced. | `{}` |
| validatingWebhookSubResources | Rule for selecting which API subresources trigger the webhook. | `['pods/ephemeralcontainers', 'pods/exec', 'pods/log', 'pods/eviction', 'pods/portforward', 'pods/proxy', 'pods/attach', 'pods/binding', 'pods/resize', 'deployments/scale', 'replicasets/scale', 'statefulsets/scale', 'replicationcontrollers/scale', 'services/proxy', 'nodes/proxy', 'services/status']` |
| validatingWebhookSubResources | Rule for selecting which API subresources trigger the webhook. | `['namespaces/finalize', 'pods/ephemeralcontainers', 'pods/exec', 'pods/log', 'pods/eviction', 'pods/portforward', 'pods/proxy', 'pods/attach', 'pods/binding', 'pods/resize', 'deployments/scale', 'replicasets/scale', 'statefulsets/scale', 'replicationcontrollers/scale', 'serviceaccounts/token', 'services/proxy', 'nodes/proxy', 'certificatesigningrequests/approval', 'services/status']` |
| validatingWebhookURL | Custom URL for Kubernetes API server to use to reach the validating webhook pod. If not set, the default of connecting via the kubernetes service endpoint is used. | `null` |
| validatingWebhookScope | The scope for the validating webhook. Does not work with `validatingWebhookCustomRules` | `*` |
| additionalValidatingWebhookConfigsToRotateCerts | The name of additional `ValidatingWebhookConfiguration`s that the gatekeeper cert rotator should manage certs for | `[]` |
Expand All @@ -169,7 +169,7 @@ information._
| mutatingWebhookMatchConditions | The match conditions written in CEL to further refine which resources will be selected by the webhook. All match conditions must evaluate to true for the webhook to be called | `[]` |
| mutatingWebhookTimeoutSeconds | The timeout for the mutating webhook in seconds | `3` |
| mutatingWebhookCustomRules | Custom rules for selecting which API resources trigger the webhook. NOTE: If you change this, ensure all your constraints are still being enforced. | `{}` |
| mutatingWebhookSubResources | Rule for selecting which API subresources trigger the webhook. | `['pods/ephemeralcontainers', 'pods/exec', 'pods/log', 'pods/eviction', 'pods/portforward', 'pods/proxy', 'pods/attach', 'pods/binding', 'deployments/scale', 'replicasets/scale', 'statefulsets/scale', 'replicationcontrollers/scale', 'services/proxy', 'nodes/proxy', 'services/status']` |
| mutatingWebhookSubResources | Rule for selecting which API subresources trigger the webhook. | `['namespaces/finalize', 'pods/ephemeralcontainers', 'pods/exec', 'pods/log', 'pods/eviction', 'pods/portforward', 'pods/proxy', 'pods/attach', 'pods/binding', 'pods/resize', 'deployments/scale', 'replicasets/scale', 'statefulsets/scale', 'replicationcontrollers/scale', 'serviceaccounts/token', 'services/proxy', 'nodes/proxy', 'certificatesigningrequests/approval', 'services/status']` |
| mutatingWebhookURL | Custom URL for Kubernetes API server to use to reach the mutating webhook pod. If not set, the default of connecting via the kubernetes service endpoint is used. | `null` |
| mutatingWebhookScope | The scope for the mutating webhook. Does not work with `mutatingWebhookCustomRules` | `*` |
| additionalMutatingWebhookConfigsToRotateCerts | The name of additional `MutatingWebhookConfiguration`s that the gatekeeper cert rotator should manage certs for | `[]` |
Expand Down
7 changes: 7 additions & 0 deletions cmd/build/helmify/static/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ validatingWebhookCheckIgnoreFailurePolicy: Fail
validatingWebhookCustomRules: {}
validatingWebhookSubResources:
[
"namespaces/finalize",
"pods/ephemeralcontainers",
"pods/exec",
"pods/log",
Expand All @@ -32,8 +33,10 @@ validatingWebhookSubResources:
"replicasets/scale",
"statefulsets/scale",
"replicationcontrollers/scale",
"serviceaccounts/token",
"services/proxy",
"nodes/proxy",
"certificatesigningrequests/approval",
"services/status",
]
validatingWebhookURL: null
Expand All @@ -55,6 +58,7 @@ mutatingWebhookTimeoutSeconds: 1
mutatingWebhookCustomRules: {}
mutatingWebhookSubResources:
[
"namespaces/finalize",
"pods/ephemeralcontainers",
"pods/exec",
"pods/log",
Expand All @@ -63,12 +67,15 @@ mutatingWebhookSubResources:
"pods/proxy",
"pods/attach",
"pods/binding",
"pods/resize",
"deployments/scale",
"replicasets/scale",
"statefulsets/scale",
"replicationcontrollers/scale",
"serviceaccounts/token",
"services/proxy",
"nodes/proxy",
"certificatesigningrequests/approval",
"services/status",
]
mutatingWebhookURL: null
Expand Down
22 changes: 22 additions & 0 deletions config/webhook/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,25 @@ webhooks:
- UPDATE
resources:
- '*'
- namespaces/finalize
- pods/ephemeralcontainers
- pods/exec
- pods/log
- pods/eviction
- pods/portforward
- pods/proxy
- pods/attach
- pods/binding
- pods/resize
- deployments/scale
- replicasets/scale
- statefulsets/scale
- replicationcontrollers/scale
- serviceaccounts/token
- services/proxy
- nodes/proxy
- certificatesigningrequests/approval
- services/status
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
Expand Down Expand Up @@ -75,6 +94,7 @@ webhooks:
- UPDATE
resources:
- '*'
- namespaces/finalize
- pods/ephemeralcontainers
- pods/exec
- pods/log
Expand All @@ -88,7 +108,9 @@ webhooks:
- replicasets/scale
- statefulsets/scale
- replicationcontrollers/scale
- serviceaccounts/token
- services/proxy
- nodes/proxy
- certificatesigningrequests/approval
- services/status
sideEffects: None
Loading
Loading