Repository navigation
feat: Review and increase E2E test coverage - #541
Conversation
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
|
✅ Deploy Preview for openworkflow-editor ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The tests can pass despite broken runtime language updates or read-only enforcement because they reapply the initial language and check content before the delayed update occurs.
2 open issues
What changed in this PR
Expands Playwright E2E coverage across the browser-facing editors and vanilla web component to reduce regressions in key user interactions.
Changes:
- Adds diagram side-panel, minimap, and Mermaid export tests, with clipboard permissions.
- Adds YAML rendering, read-only behavior, completion-context, and dark-theme tests.
- Adds web-component language and read-only attribute checks.
| File | Description |
|---|---|
packages/text-editor/tests-e2e/text-editor.spec.ts |
Adds read-only, completion-context, and dark-theme coverage using Storybook’s global color mode. |
packages/open-workflow-diagram-editor/tests-e2e/diagram-editor-interactions.spec.ts |
Adds side-panel, minimap, and Mermaid export coverage. |
packages/open-workflow-diagram-editor/playwright.config.ts |
Enables clipboard permissions for export tests. |
packages/dual-editor/tests-e2e/dual-editor.spec.ts |
Adds YAML rendering and read-only checks. |
examples/vanilla-web-component/tests-e2e/diagram-editor.spec.ts |
Adds runtime language and read-only attribute checks. |
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
fantonangeli
left a comment
There was a problem hiding this comment.
Just a couple of small comments but overall LGTM
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The JSON and YAML completion tests can pass before worker results arrive, allowing an incorrect Hello World suggestion to go undetected without first waiting for a valid schema suggestion.
1 open issue
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
|
@lornakelly we can merge this PR. |
dbb1704
into
open-workflow-specification:main

closes #233
Summary
Expand Playwright E2E coverage across the browser-facing packages:
Enable clipboard permissions in the diagram editor’s Playwright configuration. Correct the dark-mode test URL to set Storybook’s global
colorMode.