Skip to content

feat: Review and increase E2E test coverage - #541

Merged
lornakelly merged 5 commits into
open-workflow-specification:mainfrom
kumaradityaraj:e2eTest
Nov 17, 2026
Merged

lornakelly merged 5 commits into
open-workflow-specification:mainfrom
kumaradityaraj:e2eTest

Conversation

@kumaradityaraj

Copy link
Copy Markdown
Contributor

closes #233

Summary

Expand Playwright E2E coverage across the browser-facing packages:

  • Diagram editor: cover workflow and node side-panel details, minimap toggling, and Mermaid copy/download.
  • Dual editor: cover YAML rendering in both panes and read-only behavior.
  • Text editor: cover JSON and YAML read-only input, runtime read-only changes, Hello World completion context, and dark theme.
  • Vanilla web component: cover language and read-only attribute changes.

Enable clipboard permissions in the diagram editor’s Playwright configuration. Correct the dark-mode test URL to set Storybook’s global colorMode.

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 12:00
@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0ca9727

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ca9727
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6afb08c5cdd53a982c3296fc
😎 Deploy Preview https://deploy-preview-541--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The tests can pass despite broken runtime language updates or read-only enforcement because they reapply the initial language and check content before the delayed update occurs.

2 open issues
What changed in this PR

Expands Playwright E2E coverage across the browser-facing editors and vanilla web component to reduce regressions in key user interactions.

Changes:

  • Adds diagram side-panel, minimap, and Mermaid export tests, with clipboard permissions.
  • Adds YAML rendering, read-only behavior, completion-context, and dark-theme tests.
  • Adds web-component language and read-only attribute checks.
File Description
packages/​text-editor/​tests-e2e/​text-editor.spec.ts Adds read-only, completion-context, and dark-theme coverage using Storybook’s global color mode.
packages/​open-workflow-diagram-editor/​tests-e2e/​diagram-editor-interactions.spec.ts Adds side-panel, minimap, and Mermaid export coverage.
packages/​open-workflow-diagram-editor/​playwright.config.ts Enables clipboard permissions for export tests.
packages/​dual-editor/​tests-e2e/​dual-editor.spec.ts Adds YAML rendering and read-only checks.
examples/​vanilla-web-component/​tests-e2e/​diagram-editor.spec.ts Adds runtime language and read-only attribute checks.

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 12:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the expanded Playwright coverage of the editors and vanilla web component.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@fantonangeli fantonangeli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments but overall LGTM

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 13:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The JSON and YAML completion tests can pass before worker results arrive, allowing an incorrect Hello World suggestion to go undetected without first waiting for a valid schema suggestion.

1 open issue

Review effort: Balanced

Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 13:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the expanded end-to-end test coverage.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@lornakelly lornakelly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaradityaraj

Copy link
Copy Markdown
Contributor Author

@lornakelly we can merge this PR.

@lornakelly
lornakelly merged commit dbb1704 into open-workflow-specification:main Nov 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Review and increase E2E test coverage

4 participants