Repository navigation
Review and increase unit test coverage - #544
Conversation
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
|
✅ Deploy Preview for openworkflow-editor ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
Two tests can pass despite the regressions they target: stacked resizing asserts the default split, and the locale-update test also changes dictionary identity.
2 open issues
What changed in this PR
Expands unit test coverage across the editor packages to strengthen regression protection for edge cases, supporting issue #232. The changes are limited to tests.
Changes:
- Adds editor lifecycle, web-component attribute, stale-change, and pane-resizing tests.
- Covers translation fallbacks, locale detection, and provider updates.
- Adds whitespace-only document suggestions and PNG export filtering and cleanup tests.
| File | Description |
|---|---|
packages/text-editor/tests/language-service/createTextEditorLanguageService.test.ts |
Tests provider registration failure handling. |
packages/open-workflow-diagram-editor/tests/lib/exportPng.test.ts |
Tests hidden-node filtering and temporary edge-style cleanup. |
packages/language-service/tests/volar/yaml/completions.test.ts |
Tests Hello World completion for whitespace-only YAML. |
packages/language-service/tests/volar/yaml/code-lenses.test.ts |
Tests Hello World code lenses for whitespace-only YAML. |
packages/language-service/tests/volar/json/completions.test.ts |
Tests Hello World completion for whitespace-only JSON. |
packages/language-service/tests/volar/json/code-lenses.test.ts |
Tests Hello World code lenses for whitespace-only JSON. |
packages/i18n/tests/I18nProvider.test.tsx |
Tests translation updates after provider prop changes. |
packages/i18n/tests/detectLocale.test.ts |
Tests locale normalization, preference ordering, and fallbacks. |
packages/i18n/tests/createI18n.test.ts |
Tests missing dictionaries, empty translations, and selected locale. |
packages/dual-editor/tests/DualEditor.test.tsx |
Adds keyboard resizing and stacked-pane pointer tests. |
examples/vanilla-web-component/tests/dual-editor-element.test.ts |
Tests language fallback, attribute updates, and stale editor changes. |
Review effort: Balanced
Signed-off-by: Kumar Aditya Raj <sedulous.0007@gmail.com>
|
@lornakelly we can merge this pr |
e2681e8
into
open-workflow-specification:main

closes #232
Summary
Add unit tests for edge cases and behaviors across the editor packages:
onReadyis not called.