Repository navigation
fix #539 - Prevent Monaco diagnostic hover clipping in the Dual Editor - #545
Merged
Conversation
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
🦋 Changeset detectedLatest commit: 81a48b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openworkflow-editor ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
kumaradityaraj
approved these changes
Nov 18, 2026
Member
Author
|
@lornakelly can you please merge this PR? |
lornakelly
merged commit Nov 18, 2026
cabf579
into
open-workflow-specification:main
13 checks passed
fantonangeli
deleted the
issue-539-bug-Monaco-diagnostic-hover-is-clipped-near-the-top-of-the-editor
branch
November 18, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #539
Description
Fix Monaco diagnostic hover tooltips being clipped near the boundaries of the Dual Editor.
Changes
overflow: hiddenfrom the Dual Editor root container.Alternative considered
I also evaluated using Monaco's
fixedOverflowWidgetsoption , using:Both approaches passed manual tests in this repository and Quarkus Flow as well.
I chose the CSS solution to preserve Monaco's default behaviour.
If the CSS approach proves insufficient in future integrations, the Monaco configuration remains a tested alternative worth reconsidering.
How to test
pnpm startfromexamples/vanilla-web-component.Manual testing
The CSS solution was manually compared with the Monaco configuration approach. Both passed the tested scenarios, including resizing, scrolling, hover positioning, autocomplete, context menus, and layout changes.
Preview
https://fantonangeli.github.io/open-workflow-specification-editor/issue-539/

