Skip to content

feat: event filter form - #547

Merged
lornakelly merged 2 commits into
open-workflow-specification:feature/node-editingfrom
lornakelly:254/listen-event-filters
Nov 20, 2026
Merged

lornakelly merged 2 commits into
open-workflow-specification:feature/node-editingfrom
lornakelly:254/listen-event-filters

Conversation

@lornakelly

@lornakelly lornakelly commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Contributes to #254

Summary

Listen task event filters now use the standard form editing system. Previously, they had custom UX with no drill-in, no "Fields you can add" chips, no change indicators and no Custom fields support.

Main Changes

  • Each filter is a row titled by event type and source with error and "Changed" pills, and"+ Add Event Filter"
  • All 8 CloudEvents attributes are editable; unset ones appear as addable chips, extension attributes under Custom fields
  • Correlate: each key is a row with From and Expect fields
  • New event-filter-list field type (entries as drill levels) and keyed-objects field type for Correlate
  • getNestedValue, setNestedPath, deletePath now index arrays
  • activeFormView / taskErrorClassifier attribute errors from schema-derived item fields - removed hardcoded EVENT_PROPERTY_KEYS
  • useMapRows unified hook for row storage, reset syncing - shared by KeyValueMapField and KeyedObjectsField
  • AddRowButton replaces 3 duplicate "+ Add …" button implementations
  • DrillRowButton extracted from DrillRow for entry row reuse
  • isUnwritableKeyName shared key validation for Custom fields and Correlate

Verify

Storybook > Nested Editing > Listen Deep Nesting > To (event filters under ANY)

@lornakelly lornakelly changed the title Event filter form feat: event filter form Nov 18, 2026
@lornakelly
lornakelly requested a balanced review from Copilot November 18, 2026 15:38
@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7e57a6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openworkflowspec/diagram-editor Minor
@openworkflowspec/core Minor
@openworkflowspec/i18n Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7e57a6c
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6b0069bf5f241524ecfc0bd7
😎 Deploy Preview https://deploy-preview-547--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lornakelly
lornakelly force-pushed the 254/listen-event-filters branch from 29b0c5d to a57f82b Compare November 18, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing a filter breaks baseline identity, causing values from another filter to be restored and potentially hiding edits from change detection.

7 open issues
What changed in this PR

Moves Listen event filters into the editor’s standard form system, extending the nested-editing UX work tracked in #254.

Changes:

  • Adds drill-in filter rows, CloudEvents attribute chips, custom fields, and structured Correlate editing.
  • Extends array-path handling, draft state, navigation, and validation for nested filter entries.
  • Extracts shared controls and adds coverage for editing, removal, resets, and error placement.

Paths are relative to packages/open-workflow-diagram-editor/, except .changeset/.

File Description
tests/​test-utils/​panel-helpers.tsx Exposes edit sessions to tests.
tests/​side-panel/​forms/​validation/​workflowErrorClassifier.test.ts Updates expected level-error placement.
tests/​side-panel/​forms/​validation/​taskErrorClassifier.test.ts Covers schema-derived filter error routing.
tests/​side-panel/​forms/​validation/​listenEmptiedFilter.test.ts Checks emptied-filter level errors.
tests/​side-panel/​forms/​validation/​activeFormView.test.ts Checks item leaves and containers.
tests/​side-panel/​forms/​taskFormContext.test.ts Covers array reads and filter defaults.
tests/​side-panel/​forms/​TaskForm.eventFilters.test.tsx Adds integrated filter-editing coverage.
tests/​side-panel/​forms/​sectionWalkers.test.ts Includes event-filter list traversal.
tests/​side-panel/​forms/​mapEntries.test.ts Tests custom fields inside list entries.
tests/​side-panel/​forms/​eventFilters/​removeListEntry.test.ts Tests entry-state renumbering.
tests/​side-panel/​forms/​drill/​drill.test.ts Tests synthesized filter drill levels.
tests/​side-panel/​forms/​customFields/​EventFilterListField.test.tsx Removes legacy control tests.
tests/​fixtures/​workflows.ts Adds Listen filter fixtures.
tests/​fixtures/​taskValidation.ts Updates missing-list error expectations.
tests/​core/​taskDraft.test.ts Covers array writes and empty-object cleanup.
tests/​core/​schemaToFormFields.test.ts Tests filter and keyed-object descriptors.
src/​side-panel/​SidePanel.css Styles filter rows and Correlate entries.
src/​side-panel/​forms/​validation/​taskErrorClassifier.ts Routes filter errors using descriptors.
src/​side-panel/​forms/​validation/​activeFormView.ts Records filter item leaves and containers.
src/​side-panel/​forms/​taskFormContext.ts Extends defaults and traversal for new fields.
src/​side-panel/​forms/​mapEntries.ts Shares path-safe key validation.
src/​side-panel/​forms/​FormField.tsx Dispatches new structured field renderers.
src/​side-panel/​forms/​FieldList.tsx Clears stored Correlate rows on removal.
src/​side-panel/​forms/​FieldControl.tsx Removes legacy filter-control dispatch.
src/​side-panel/​forms/​eventFilters/​removeListEntry.ts Renumbers entry-indexed editor state.
src/​side-panel/​forms/​eventFilters/​EventFilterListField.tsx Implements drill-row filter lists.
src/​side-panel/​forms/​eventFilters/​entrySummary.ts Derives filter titles and summaries.
src/​side-panel/​forms/​eventFilters/​EntryRow.tsx Renders filter rows and status pills.
src/​side-panel/​forms/​drill/​useDrillNavigation.ts Supports entry labels and inline layouts.
src/​side-panel/​forms/​drill/​DrillRow.tsx Extracts a reusable drill-row button.
src/​side-panel/​forms/​drill/​drill.ts Resolves indexed filter drill targets.
src/​side-panel/​forms/​draft.ts Passes filter-list paths into draft cleanup.
src/​side-panel/​forms/​customFields/​useMapRows.ts Shares row persistence and reset handling.
src/​side-panel/​forms/​customFields/​StringListField.tsx Uses the shared add-row button.
src/​side-panel/​forms/​customFields/​KeyValueMapField.tsx Uses shared row state and controls.
src/​side-panel/​forms/​customFields/​KeyedObjectsField.tsx Adds structured Correlate key editing.
src/​side-panel/​forms/​customFields/​index.ts Removes the legacy filter export.
src/​side-panel/​forms/​customFields/​EventFilterListField.tsx Removes the bespoke filter editor.
src/​side-panel/​forms/​customFields/​AddRowButton.tsx Provides a shared add-row control.
src/​side-panel/​forms/​addedFields.ts Shifts added-field paths after removal.
src/​i18n/​locales/​en.ts Adds Correlate key labels.
src/​core/​taskDraft.ts Supports indexed paths and empty-object cleanup.
src/​core/​schemaToFormFields.ts Adds keyed-object descriptors and filter labels.
src/​core/​paths.ts Adds numeric path-segment detection.
.changeset/​listen-event-filters.md Records the editor feature release.

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Named correlation keys can be silently discarded instead of validated, and Cancel or undo can leave a stale filter editor that recreates removed entries.

1 open issue
1 resolved since last review

Review effort: Balanced

Signed-off-by: lornakelly <lornakelly88@gmail.com>
@lornakelly
lornakelly force-pushed the 254/listen-event-filters branch from 1cfffda to 1b8ba88 Compare November 19, 2026 15:11

@kumaradityaraj kumaradityaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. LGTM

Signed-off-by: lornakelly <lornakelly88@gmail.com>

@handreyrc handreyrc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks

@lornakelly
lornakelly merged commit f149d02 into open-workflow-specification:feature/node-editing Nov 20, 2026
10 checks passed
@lornakelly
lornakelly deleted the 254/listen-event-filters branch November 20, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants